From: "Stanley Chang[昌育德]" <stanley_chang@realtek.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>, Felipe Balbi <balbi@kernel.org>
Subject: RE: [PATCH v2 2/2] dt-bindings: usb: snps,dwc3: Add 'snps,global-regs-starting-offset' quirk
Date: Thu, 13 Apr 2023 14:58:01 +0000 [thread overview]
Message-ID: <9f6abbe7a6fd479c98e2fd6c1080ad8a@realtek.com> (raw)
In-Reply-To: <167e4a8c-3ebd-92b7-1481-947f08901f97@kernel.org>
> On 13/04/2023 06:25, Stanley Chang wrote:
> > Add a new 'snps,global-regs-starting-offset' DT to dwc3 core to remap
> > the global register start address
> >
> > The RTK DHC SoCs were designed the global register address offset at
> > 0x8100. The default address is at DWC3_GLOBALS_REGS_START (0xc100).
> > Therefore, add the property of device-tree to adjust this start address.
> >
> > Signed-off-by: Stanley Chang <stanley_chang@realtek.com>
> > ---
> > v1 to v2 change:
> > 1. Change the name of the property "snps,global-regs-starting-offset".
> > ---
>
> Didn't you got already comment for this patch? How did you implement it?
>
> Also, I asked you multiple times:
>
> Please use scripts/get_maintainers.pl to get a list of necessary people and lists
> to CC. It might happen, that command when run on an older kernel, gives
> you outdated entries. Therefore please be sure you base your patches on
> recent Linux kernel.
>
> I don't understand why you ignore this.
>
> NAK, patch is not correct.
>
> Best regards,
> Krzysztof
>
Thank you for your patient guidance.
Because I'm not familiar with the review process and didn't use scripts/get_maintainers.pl properly in the initial email thread.
Therefore, this series of errors was caused. Sorry for the confusion.
Now I know how to use the script properly.
After correcting the maintainer's suggestion, I'll restart a new email thread and review again.
next prev parent reply other threads:[~2023-04-13 14:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230412033006.10859-1-stanley_chang@realtek.com>
[not found] ` <20230412033006.10859-2-stanley_chang@realtek.com>
[not found] ` <955cc334-eaac-5880-51cf-8ab171f0ef48@kernel.org>
2023-04-12 11:11 ` [PATCH v2 2/2] dt-bindings: usb: snps,dwc3: Add 'snps,global-regs-starting-offset' quirk Stanley Chang[昌育德]
2023-04-12 14:13 ` Krzysztof Kozlowski
[not found] ` <CAL_JsqLqTHbHjB1qiLduhzvTaO7EBMgL6KYqZJtgStGVGtX1vQ@mail.gmail.com>
2023-04-13 2:53 ` Stanley Chang[昌育德]
2023-04-14 9:08 ` Krzysztof Kozlowski
2023-04-14 9:36 ` Stanley Chang[昌育德]
2023-04-13 4:25 ` Stanley Chang
2023-04-13 7:32 ` Krzysztof Kozlowski
2023-04-13 14:58 ` Stanley Chang[昌育德] [this message]
2023-04-13 16:36 ` Krzysztof Kozlowski
2023-04-14 2:12 ` Stanley Chang[昌育德]
2023-04-14 9:05 ` Krzysztof Kozlowski
2023-04-13 13:00 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f6abbe7a6fd479c98e2fd6c1080ad8a@realtek.com \
--to=stanley_chang@realtek.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).