From: Changhuang Liang <changhuang.liang@starfivetech.com>
To: Conor Dooley <conor@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Emil Renner Berthing <kernel@esmil.dk>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Walker Chen <walker.chen@starfivetech.com>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-riscv@lists.infradead.org>
Subject: Re: [PATCH v1 5/7] soc: starfive: Use call back to parse device tree resources
Date: Wed, 12 Apr 2023 15:52:41 +0800 [thread overview]
Message-ID: <9f729ae6-8b20-e77c-18f7-cbe093f8a3b9@starfivetech.com> (raw)
In-Reply-To: <20230411-stimuli-reapprove-4659d50e5d2e@spud>
On 2023/4/12 5:06, Conor Dooley wrote:
> On Mon, Apr 10, 2023 at 11:47:41PM -0700, Changhuang Liang wrote:
>> Different compatible parse device tree resources work in different ways.
>
> Right now there is only one compatible, so this commit message needs to
> be expanded on to provide more information on your motivation.
>
OK, will add more commit message.
>> Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
>
>> static int jh71xx_pmu_init_domain(struct jh71xx_pmu *pmu, int index)
>> {
[...]
>>
>> match_data = of_device_get_match_data(dev);
>> if (!match_data)
>> return -EINVAL;
>>
>> + if (match_data->pmu_parse_dt) {
>
> How can this be false?
>
> Cheers,
> Conor.
Yes, it will not be false, I will delete this if condition
next prev parent reply other threads:[~2023-04-12 7:52 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 6:47 [PATCH v1 0/7] Add JH7110 DPHY PMU support Changhuang Liang
2023-04-11 6:47 ` [PATCH v1 1/7] dt-bindings: power: Constrain properties for JH7110 PMU Changhuang Liang
2023-04-11 20:13 ` Conor Dooley
2023-04-12 2:51 ` Changhuang Liang
2023-04-12 8:35 ` Krzysztof Kozlowski
2023-04-12 8:51 ` Changhuang Liang
2023-04-12 9:42 ` Conor Dooley
2023-04-12 11:29 ` Krzysztof Kozlowski
2023-04-13 2:11 ` Changhuang Liang
2023-04-14 2:20 ` Changhuang Liang
2023-04-17 18:55 ` Conor Dooley
2023-04-18 1:38 ` Changhuang Liang
2023-04-14 6:27 ` Conor Dooley
2023-04-11 6:47 ` [PATCH v1 2/7] soc: starfive: Replace SOC_STARFIVE with ARCH_SATRFIVE Changhuang Liang
2023-04-11 20:13 ` Conor Dooley
2023-04-12 2:11 ` Walker Chen
2023-04-12 2:52 ` Changhuang Liang
2023-04-11 6:47 ` [PATCH v1 3/7] soc: starfive: Modify ioremap to regmap Changhuang Liang
2023-04-11 20:26 ` Conor Dooley
2023-04-12 3:03 ` Changhuang Liang
2023-04-11 6:47 ` [PATCH v1 4/7] soc: starfive: Add pmu type operation Changhuang Liang
2023-04-11 20:52 ` Conor Dooley
2023-04-12 6:42 ` Changhuang Liang
2023-04-11 6:47 ` [PATCH v1 5/7] soc: starfive: Use call back to parse device tree resources Changhuang Liang
2023-04-11 21:06 ` Conor Dooley
2023-04-12 7:52 ` Changhuang Liang [this message]
2023-04-12 6:07 ` Walker Chen
2023-04-12 6:27 ` Conor Dooley
2023-04-11 6:47 ` [PATCH v1 6/7] soc: starfive: Add dphy pmu support Changhuang Liang
2023-04-11 21:15 ` Conor Dooley
2023-04-12 7:31 ` Changhuang Liang
2023-04-12 8:19 ` Changhuang Liang
2023-04-11 6:47 ` [PATCH v1 7/7] riscv: dts: starfive: Add dphy rx pmu node Changhuang Liang
2023-04-11 20:09 ` [PATCH v1 0/7] Add JH7110 DPHY PMU support Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f729ae6-8b20-e77c-18f7-cbe093f8a3b9@starfivetech.com \
--to=changhuang.liang@starfivetech.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@esmil.dk \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=walker.chen@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).