From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94E86C77B6E for ; Wed, 12 Apr 2023 07:52:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229836AbjDLHw5 (ORCPT ); Wed, 12 Apr 2023 03:52:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229513AbjDLHwz (ORCPT ); Wed, 12 Apr 2023 03:52:55 -0400 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFA4E5FEF; Wed, 12 Apr 2023 00:52:44 -0700 (PDT) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 6484024DF03; Wed, 12 Apr 2023 15:52:43 +0800 (CST) Received: from EXMBX162.cuchost.com (172.16.6.72) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Wed, 12 Apr 2023 15:52:43 +0800 Received: from [192.168.125.82] (113.72.145.176) by EXMBX162.cuchost.com (172.16.6.72) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Wed, 12 Apr 2023 15:52:42 +0800 Message-ID: <9f729ae6-8b20-e77c-18f7-cbe093f8a3b9@starfivetech.com> Date: Wed, 12 Apr 2023 15:52:41 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v1 5/7] soc: starfive: Use call back to parse device tree resources Content-Language: en-US To: Conor Dooley CC: Rob Herring , Krzysztof Kozlowski , Emil Renner Berthing , Paul Walmsley , Palmer Dabbelt , Albert Ou , Walker Chen , , , References: <20230411064743.273388-1-changhuang.liang@starfivetech.com> <20230411064743.273388-6-changhuang.liang@starfivetech.com> <20230411-stimuli-reapprove-4659d50e5d2e@spud> From: Changhuang Liang In-Reply-To: <20230411-stimuli-reapprove-4659d50e5d2e@spud> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [113.72.145.176] X-ClientProxiedBy: EXCAS064.cuchost.com (172.16.6.24) To EXMBX162.cuchost.com (172.16.6.72) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2023/4/12 5:06, Conor Dooley wrote: > On Mon, Apr 10, 2023 at 11:47:41PM -0700, Changhuang Liang wrote: >> Different compatible parse device tree resources work in different ways. > > Right now there is only one compatible, so this commit message needs to > be expanded on to provide more information on your motivation. > OK, will add more commit message. >> Signed-off-by: Changhuang Liang > >> static int jh71xx_pmu_init_domain(struct jh71xx_pmu *pmu, int index) >> { [...] >> >> match_data = of_device_get_match_data(dev); >> if (!match_data) >> return -EINVAL; >> >> + if (match_data->pmu_parse_dt) { > > How can this be false? > > Cheers, > Conor. Yes, it will not be false, I will delete this if condition