From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Billy Tsai <billy_tsai@aspeedtech.com>,
"jdelvare@suse.com" <jdelvare@suse.com>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"joel@jms.id.au" <joel@jms.id.au>,
"andrew@aj.id.au" <andrew@aj.id.au>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>,
"corbet@lwn.net" <corbet@lwn.net>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"patrick@stwcx.xyz" <patrick@stwcx.xyz>
Subject: Re: [v6 1/4] dt-bindings: pwm: Add ASPEED PWM Control documentation
Date: Thu, 8 Jun 2023 10:36:36 +0200 [thread overview]
Message-ID: <9f8a9208-62d4-0c96-7d1c-a452d3d7e799@linaro.org> (raw)
In-Reply-To: <SG2PR06MB336528007D2685F8D95DF4078B50A@SG2PR06MB3365.apcprd06.prod.outlook.com>
On 08/06/2023 10:21, Billy Tsai wrote:
> On 08/06/2023 09:47, Billy Tsai wrote:
> >>
> >> >> +
> >> >> +allOf:
> >> >> + - $ref: pwm.yaml#
> >> >> +
> >> >> +properties:
> >> >> + compatible:
> >> >> + enum:
> >> >> + - aspeed,ast2600-pwm
> >> >> +
> >> >> + "#pwm-cells":
> >> >> + const: 3
> >>
> >> > 3 cells? For one PWM? What are they?
> >>
> >> channel, period and polarity.
>
> > Don't cut my responses. You wrote you have one PWM output, so only one
> > channel. What do you put then in the channel?
>
> You need to put 0 in the cell of the channel, the example of the dts usage will like following:
If you always put 0 isn't this a proof that it's wrong?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-06-08 8:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 2:18 [v6 0/4] Support pwm/tach driver for aspeed ast26xx Billy Tsai
2023-06-08 2:18 ` [v6 1/4] dt-bindings: pwm: Add ASPEED PWM Control documentation Billy Tsai
2023-06-08 6:39 ` Krzysztof Kozlowski
2023-06-08 6:46 ` Krzysztof Kozlowski
[not found] ` <SG2PR06MB3365DD80EA2FD026D400C4A78B50A@SG2PR06MB3365.apcprd06.prod.outlook.com>
2023-06-08 7:54 ` Krzysztof Kozlowski
[not found] ` <SG2PR06MB336528007D2685F8D95DF4078B50A@SG2PR06MB3365.apcprd06.prod.outlook.com>
2023-06-08 8:36 ` Krzysztof Kozlowski [this message]
[not found] ` <SG2PR06MB3365FCF5BEA6555EC503EFEC8B50A@SG2PR06MB3365.apcprd06.prod.outlook.com>
2023-06-08 9:26 ` Krzysztof Kozlowski
2023-06-08 8:39 ` Krzysztof Kozlowski
[not found] ` <SG2PR06MB3365558F9A3127744CEF1C068B50A@SG2PR06MB3365.apcprd06.prod.outlook.com>
2023-06-08 9:27 ` Krzysztof Kozlowski
2023-06-08 2:18 ` [v6 2/4] dt-bindings: hwmon: Add ASPEED TACH " Billy Tsai
2023-06-08 4:58 ` Guenter Roeck
[not found] ` <SG2PR06MB3365E360F3FCDE639F3D2D1E8B50A@SG2PR06MB3365.apcprd06.prod.outlook.com>
2023-06-08 13:18 ` Guenter Roeck
2023-06-08 6:40 ` Krzysztof Kozlowski
2023-06-08 2:18 ` [v6 3/4] pwm: Add Aspeed ast2600 PWM support Billy Tsai
2023-07-18 7:08 ` Thierry Reding
2023-06-08 2:18 ` [v6 4/4] hwmon: Add Aspeed ast2600 TACH support Billy Tsai
2023-06-08 5:01 ` Guenter Roeck
2023-06-08 6:37 ` [v6 0/4] Support pwm/tach driver for aspeed ast26xx Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f8a9208-62d4-0c96-7d1c-a452d3d7e799@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andrew@aj.id.au \
--cc=billy_tsai@aspeedtech.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=p.zabel@pengutronix.de \
--cc=patrick@stwcx.xyz \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).