From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73B3FC7EE25 for ; Thu, 8 Jun 2023 08:36:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235022AbjFHIgn (ORCPT ); Thu, 8 Jun 2023 04:36:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232984AbjFHIgm (ORCPT ); Thu, 8 Jun 2023 04:36:42 -0400 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0162269E for ; Thu, 8 Jun 2023 01:36:40 -0700 (PDT) Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-978863fb00fso70745566b.3 for ; Thu, 08 Jun 2023 01:36:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686213399; x=1688805399; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KP6FTQbezAovuHn8DXvJcqsrbsf1/vJCY3Cy9QhDcuY=; b=l4G/0deA780yke9lCVpsQz9+5T9PPXsj68cOKT9hCDkYvKS49eun7pxuHW16iEZP/b T1rcaMRIMwY+8YXee5rtf22mLEczKIXKY1g6IJBzTYh471ju92mHUqknGGuLD0DTvK8Z gFaYicpruiY2UWFTlTY1B+9YGcvYGv9AmWpOuzaH0SqhJydXhDzbO6yxWhnK0fU60jhp bHyzWnQ2qhDJ8aEb4KEPr7YSKlujuWbYyaEDzbcjNUEjblTOKuqMBaiFHiZdGrUpFjbs N4XexIeytr493Pqqf1a1u5OohNOLFMz2kR6lq6Xx3EkEt8dXjJ7INiOHPvv8G4fVb2dz atLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686213399; x=1688805399; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KP6FTQbezAovuHn8DXvJcqsrbsf1/vJCY3Cy9QhDcuY=; b=RNgznafgtdvhjpejeUmW7qZHH9FTsb7VRSrxgqAsGKzHjgS/o497FdilTN/Il7qSiC mB9opp+qvlWcuQaoHXRHGmcHpYHC88XppovHhtj5rvKJGWfAEFBckJki5c9rdgmXXU2q RXC39H0bALVRorKOua0B1Cn+uy8faO8sQCroQF4pWcGNQvyaQ3QWWYMjKaKW3tY9Ahd9 q8s6qtlLPHFj8kN9f3QOOhZN1k/d5FkCBoxvPgEUerP3fUeqvxbbx2jPIAReA+j/RR/w sd1Xhwm6XcWdZE3HEedTAJeJFS+Ska3/AwJ8pdtvkYXfStz23Um3Q5y+dbOY97RzFPyx /8dg== X-Gm-Message-State: AC+VfDwJvLspEGj3uwUDSX8sNm8Z+GazqxVUXsb9Idxg4DMq/3i/8baC suNF2Dod2XOWCdODaoNJaGdYuQ== X-Google-Smtp-Source: ACHHUZ4Rr0xFX57yVQfz1/k8GLc/jFvOpE/oXWcHFHi0S+gaR1ek3G1G18/OfI6o6YcStn+m8N0Kig== X-Received: by 2002:a17:907:1c15:b0:96a:8c13:8dc0 with SMTP id nc21-20020a1709071c1500b0096a8c138dc0mr9105461ejc.37.1686213399231; Thu, 08 Jun 2023 01:36:39 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id a14-20020a1709063a4e00b0097456b4085fsm383939ejf.190.2023.06.08.01.36.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Jun 2023 01:36:38 -0700 (PDT) Message-ID: <9f8a9208-62d4-0c96-7d1c-a452d3d7e799@linaro.org> Date: Thu, 8 Jun 2023 10:36:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [v6 1/4] dt-bindings: pwm: Add ASPEED PWM Control documentation Content-Language: en-US To: Billy Tsai , "jdelvare@suse.com" , "linux@roeck-us.net" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "joel@jms.id.au" , "andrew@aj.id.au" , "thierry.reding@gmail.com" , "u.kleine-koenig@pengutronix.de" , "corbet@lwn.net" , "p.zabel@pengutronix.de" , "linux-hwmon@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "linux-pwm@vger.kernel.org" , "linux-doc@vger.kernel.org" , "patrick@stwcx.xyz" References: <20230608021839.12769-1-billy_tsai@aspeedtech.com> <20230608021839.12769-2-billy_tsai@aspeedtech.com> <4dffd320-8e30-fb30-6ded-79519afddc21@linaro.org> <61278e12-ba39-4503-ca74-a7118b0f6e99@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 08/06/2023 10:21, Billy Tsai wrote: > On 08/06/2023 09:47, Billy Tsai wrote: > >> > >> >> + > >> >> +allOf: > >> >> + - $ref: pwm.yaml# > >> >> + > >> >> +properties: > >> >> + compatible: > >> >> + enum: > >> >> + - aspeed,ast2600-pwm > >> >> + > >> >> + "#pwm-cells": > >> >> + const: 3 > >> > >> > 3 cells? For one PWM? What are they? > >> > >> channel, period and polarity. > > > Don't cut my responses. You wrote you have one PWM output, so only one > > channel. What do you put then in the channel? > > You need to put 0 in the cell of the channel, the example of the dts usage will like following: If you always put 0 isn't this a proof that it's wrong? Best regards, Krzysztof