From: Alex Elder <elder@linaro.org>
To: Sujit Kautkar <sujitka@chromium.org>,
Andy Gross <agross@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>
Cc: swboyd@chromium.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] arm64: dts: qcom: sc7180-trogdor: Enable IPA on LTE only SKUs
Date: Mon, 20 Sep 2021 14:45:33 -0500 [thread overview]
Message-ID: <9f94de2e-eb1b-225e-937d-55855d95a4ac@linaro.org> (raw)
In-Reply-To: <20210920113220.v1.1.I904da9664f294fcf222f6f378d37eaadd72ca92e@changeid>
On 9/20/21 1:32 PM, Sujit Kautkar wrote:
> Enable the IPA node for LTE and skip for wifi-only SKUs
>
> Signed-off-by: Sujit Kautkar <sujitka@chromium.org>
Looks good to me. Thanks Sujit.
Reviewed-by: Alex Elder <elder@linaro.org>
> ---
>
> arch/arm64/boot/dts/qcom/sc7180-trogdor-lte-sku.dtsi | 11 +++++++++++
> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 11 -----------
> 2 files changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lte-sku.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lte-sku.dtsi
> index 469aad4e5948c..fd4b712037542 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lte-sku.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lte-sku.dtsi
> @@ -17,3 +17,14 @@ &remoteproc_mpss {
> firmware-name = "qcom/sc7180-trogdor/modem/mba.mbn",
> "qcom/sc7180-trogdor/modem/qdsp6sw.mbn";
> };
> +
> +&ipa {
> + status = "okay";
> +
> + /*
> + * Trogdor doesn't have QHEE (Qualcomm's EL2 blob), so the
> + * modem needs to cover certain init steps (GSI init), and
> + * the AP needs to wait for it.
> + */
> + modem-init;
> +};
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> index 6e96024a487cd..3d8b9c6b21a85 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> @@ -754,17 +754,6 @@ alc5682: codec@1a {
> };
> };
>
> -&ipa {
> - status = "okay";
> -
> - /*
> - * Trogdor doesn't have QHEE (Qualcomm's EL2 blob), so the
> - * modem needs to cover certain init steps (GSI init), and
> - * the AP needs to wait for it.
> - */
> - modem-init;
> -};
> -
> &lpass_cpu {
> status = "okay";
>
>
prev parent reply other threads:[~2021-09-21 1:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 18:32 [PATCH v1] arm64: dts: qcom: sc7180-trogdor: Enable IPA on LTE only SKUs Sujit Kautkar
2021-09-20 19:45 ` Alex Elder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f94de2e-eb1b-225e-937d-55855d95a4ac@linaro.org \
--to=elder@linaro.org \
--cc=agross@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sujitka@chromium.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).