From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D682EC433EF for ; Tue, 21 Sep 2021 01:39:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B657161168 for ; Tue, 21 Sep 2021 01:39:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233059AbhIUBkn (ORCPT ); Mon, 20 Sep 2021 21:40:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232234AbhIUBjX (ORCPT ); Mon, 20 Sep 2021 21:39:23 -0400 Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69154C03D753 for ; Mon, 20 Sep 2021 12:45:35 -0700 (PDT) Received: by mail-io1-xd2d.google.com with SMTP id s20so15105895ioa.4 for ; Mon, 20 Sep 2021 12:45:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=N7n5x8sXHuAzu3+RIwr9lpXQmI9SOiXEYfpRq5wrut4=; b=JqgTQlIWTovRoLk+BvUsk/awete9Lsf3s0uK7GhVO+TH3Rz+iie+EYRFU9ptMoSeF0 7fQGY9Qx/OamC+mP6z1l3HAkHTlNILXb4L2qCmoRVpYQqmUojC4uzBY7vK8nBxegThA3 goZovTiD2pJjGIKrjXjWlb9aTpF++C6Uxyir1hNZ8RKjN9o3GO/7XkqZpGhcltmPjzjQ V10YpC5pWiLDeqbwO45upnu8RuA+od5MLhW062DiXWANTEWpnytIsh+pmrEGEaRLZU+b Gr8Jw4Wa5OxeqIfjDm8ugaUeoZTn5f3HXu27Szv4txUKCZcb2AquCZ65bzsE7S7Og2w1 HUeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=N7n5x8sXHuAzu3+RIwr9lpXQmI9SOiXEYfpRq5wrut4=; b=ZEsDTiKq14b18RhRh8f/ENDncXBpiPgEK8kAzVyOh3m4BRKFfVp9gDMMta86NKi/8e IzgcxgQVFCGbculK60xxoRZaCbncbOARl4ZsqyOm7eozFjdtSOJdMm3n421yxOmdS1km o+Y+l9aGg28kwZLOiBJm+fEtUA3aEHYHW/xgRL/VP4yL5dXmnvAkzsNFxzkWEHobBdAU lSMNp2pkNOC7/KoYwMVsGRE5IHEcIA2s8H1ZHg4MzdwRhlGrnNsXxlYXolIjj0UHlwzX cewuG8+qHT1NbDW6RHoXZRpPwTAo7QPHFwbK/veNZaLQOcfpOwD6vz1kv+JpNOLvwhiu ZBRg== X-Gm-Message-State: AOAM5301p1Xud4O0PRGDl59aqYGRlOb/jWVE3h3N7czus5eq4vVxwpxh 124rZwdTsVXuY6oFEdjOAhyJUA== X-Google-Smtp-Source: ABdhPJypcjxV8kGKDIjn8BoxxMAFqbAhAglu2GGK/YeLbTIaWJLrqtR6Wu+A2QH/uxXLXLc8WtLthw== X-Received: by 2002:a02:19c9:: with SMTP id b192mr21061667jab.67.1632167134657; Mon, 20 Sep 2021 12:45:34 -0700 (PDT) Received: from [172.22.22.4] (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.googlemail.com with ESMTPSA id e13sm8942241iod.36.2021.09.20.12.45.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Sep 2021 12:45:34 -0700 (PDT) Subject: Re: [PATCH v1] arm64: dts: qcom: sc7180-trogdor: Enable IPA on LTE only SKUs To: Sujit Kautkar , Andy Gross , Mark Rutland , Rob Herring Cc: swboyd@chromium.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210920113220.v1.1.I904da9664f294fcf222f6f378d37eaadd72ca92e@changeid> From: Alex Elder Message-ID: <9f94de2e-eb1b-225e-937d-55855d95a4ac@linaro.org> Date: Mon, 20 Sep 2021 14:45:33 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210920113220.v1.1.I904da9664f294fcf222f6f378d37eaadd72ca92e@changeid> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 9/20/21 1:32 PM, Sujit Kautkar wrote: > Enable the IPA node for LTE and skip for wifi-only SKUs > > Signed-off-by: Sujit Kautkar Looks good to me. Thanks Sujit. Reviewed-by: Alex Elder > --- > > arch/arm64/boot/dts/qcom/sc7180-trogdor-lte-sku.dtsi | 11 +++++++++++ > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 11 ----------- > 2 files changed, 11 insertions(+), 11 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lte-sku.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lte-sku.dtsi > index 469aad4e5948c..fd4b712037542 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lte-sku.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lte-sku.dtsi > @@ -17,3 +17,14 @@ &remoteproc_mpss { > firmware-name = "qcom/sc7180-trogdor/modem/mba.mbn", > "qcom/sc7180-trogdor/modem/qdsp6sw.mbn"; > }; > + > +&ipa { > + status = "okay"; > + > + /* > + * Trogdor doesn't have QHEE (Qualcomm's EL2 blob), so the > + * modem needs to cover certain init steps (GSI init), and > + * the AP needs to wait for it. > + */ > + modem-init; > +}; > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > index 6e96024a487cd..3d8b9c6b21a85 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > @@ -754,17 +754,6 @@ alc5682: codec@1a { > }; > }; > > -&ipa { > - status = "okay"; > - > - /* > - * Trogdor doesn't have QHEE (Qualcomm's EL2 blob), so the > - * modem needs to cover certain init steps (GSI init), and > - * the AP needs to wait for it. > - */ > - modem-init; > -}; > - > &lpass_cpu { > status = "okay"; > >