From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AF36C83F12 for ; Mon, 28 Aug 2023 06:55:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229436AbjH1GzN (ORCPT ); Mon, 28 Aug 2023 02:55:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229556AbjH1GzM (ORCPT ); Mon, 28 Aug 2023 02:55:12 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC3EAE0 for ; Sun, 27 Aug 2023 23:55:08 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-52a3ff5f0abso3839133a12.1 for ; Sun, 27 Aug 2023 23:55:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693205707; x=1693810507; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7ptVbyds4HPxErszif0wxUcSHmLuVkPZo/yMJrdkcDs=; b=u0I+AIPq3WtDnTAreCyy90MCKvMJSVNboKn65rhdsoXltifxtaS6henYb7U0KLvsNW i3wZxjTfgqN2DGvK+g6X5zL58jJHihTJBSEV+1gP9QOU5Tnx/Qg8QEVzU8jL6D/72qBR stTOBbz4Wfqgfqu5+Fmk10KypDISxN8gdjsRZMcWX3qg+cWAIKaJaLJFRV61/btyTdXG d+TWmGQoixmcQpB76hT7R8fMtEONUFXi5BsUvJgwln7TnTNjCPCENZT97Y9ix7MoWkrX ewjOuQc4ovmaamkKRAx4EYWbGB4nPpyqXRpu5ZAkl3FQP5V7gjaSEr1qFs+64bVfk80/ iMZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693205707; x=1693810507; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7ptVbyds4HPxErszif0wxUcSHmLuVkPZo/yMJrdkcDs=; b=ClMrc5Uwb8P3HaBnN9rXVh1jgKwKOJ4fnAgZLSFobISwrHKUQCtdMMjiGCCJvjv88y vXEHHOPSdB8Pi6gscvpy94jIcFp2PsM9pYRqMRBmvIG2zi3vInt3j0Q4+tSDUigUIjF+ Mk3ivL0goxSLogQ4P+oU6iU/cEGxG1rj5kuh1VTrKNFe5/tBWwgJFp+DLsyWlPhtm6qf PaQL+KS0+2GMy377ful+WqwqX0gc/itOQmRdhSQG8x/XIWtpz1/bViYZZiq38u2PvWDF wUba5mvQzwbihDDUsHAmIRsOwtEd8/nVuxF0bxR0wdqEs8xj+Wz7nL2T0q77Ia2xs+/7 HRXA== X-Gm-Message-State: AOJu0YzJOkgjZoMyqZppZRig897qMJnv6ioOAOpzLutiwvnM/Gu60ANJ ct4cZzlM/ARs63y72mQuZUQsFQ== X-Google-Smtp-Source: AGHT+IE1kB47fLHbKb5MQZ/Hd2Twqa/OpuzYsNApKa6FCmlGY1PnQViOFPgPIAAC/uHevNyPrQA4Nw== X-Received: by 2002:a05:6402:545:b0:523:1400:2d7c with SMTP id i5-20020a056402054500b0052314002d7cmr16646990edx.35.1693205707362; Sun, 27 Aug 2023 23:55:07 -0700 (PDT) Received: from [192.168.0.22] ([77.252.47.225]) by smtp.gmail.com with ESMTPSA id o7-20020a056402038700b0052565298bedsm4094401edv.34.2023.08.27.23.55.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Aug 2023 23:55:06 -0700 (PDT) Message-ID: <9f983d06-e82b-e572-e007-18d39c15ead7@linaro.org> Date: Mon, 28 Aug 2023 08:55:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [EXT] Re: [PATCH v5 01/11] dt-bindings: arm: fsl: add imx-se-fw binding doc Content-Language: en-US To: Varun Sethi , Greg Kroah-Hartman , Krzysztof Kozlowski Cc: Rob Herring , Pankaj Gupta , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "clin@suse.com" , "conor+dt@kernel.org" , "pierre.gondois@arm.com" , Jacky Bai , Clark Wang , Wei Fang , Peng Fan , Bough Chen , "festevam@gmail.com" , dl-linux-imx , "davem@davemloft.net" , "krzysztof.kozlowski+dt@linaro.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Gaurav Jain , "alexander.stein@ew.tq-group.com" , Sahil Malhotra , Aisheng Dong References: <20230823073330.1712721-1-pankaj.gupta@nxp.com> <20230823073330.1712721-2-pankaj.gupta@nxp.com> <20230823124340.GA2022486-robh@kernel.org> <574e93da-ec74-f1a2-7170-c16bb225a2bb@kernel.org> <2023082422-proofing-dispense-1a1a@gregkh> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 28/08/2023 08:00, Varun Sethi wrote: > Hi Greg, > >> -----Original Message----- >> From: Greg Kroah-Hartman >> Sent: Friday, August 25, 2023 12:54 AM >> To: Krzysztof Kozlowski >> Cc: Rob Herring ; Pankaj Gupta >> ; shawnguo@kernel.org; s.hauer@pengutronix.de; >> kernel@pengutronix.de; clin@suse.com; conor+dt@kernel.org; >> pierre.gondois@arm.com; Jacky Bai ; Clark Wang >> ; Wei Fang ; Peng Fan >> ; Bough Chen ; >> festevam@gmail.com; dl-linux-imx ; >> davem@davemloft.net; krzysztof.kozlowski+dt@linaro.org; linux-arm- >> kernel@lists.infradead.org; devicetree@vger.kernel.org; linux- >> kernel@vger.kernel.org; Gaurav Jain ; >> alexander.stein@ew.tq-group.com; Sahil Malhotra >> ; Aisheng Dong ; Varun >> Sethi >> Subject: [EXT] Re: [PATCH v5 01/11] dt-bindings: arm: fsl: add imx-se-fw >> binding doc >> >> Caution: This is an external email. Please take care when clicking links > or >> opening attachments. When in doubt, report the message using the 'Report >> this email' button >> >> >> On Thu, Aug 24, 2023 at 08:45:41PM +0200, Krzysztof Kozlowski wrote: >>> On 23/08/2023 14:43, Rob Herring wrote: >>>>> + | >>>>> + +------------------------------------------------------ | >>>>> + | | | | >>>>> + userspace /dev/ele_muXch0 | | | >>>>> + /dev/ele_muXch1 | | >>>>> + /dev/ele_muXchY | >>>>> + | >>>>> + >>>>> + When a user sends a command to the firmware, it registers its >>>>> + device_ctx as waiter of a response from firmware. >>>>> + >>>>> + A user can be registered as receiver of command from the ELE. >>>>> + Create char devices in /dev as channels of the form >>>>> + /dev/ele_muXchY with X the id of the driver and Y for each >>>>> + users. It allows to send and receive messages to the NXP >>>>> + EdgeLock Enclave IP firmware on NXP SoC, where current possible >> value, i.e., supported SoC(s) are imx8ulp, imx93. >>>> >>>> Looks like a bunch of Linux details which don't belong in the binding. >>>> >>>> Why do you need your own custom interface to userspace? No one else >>>> has a similar feature in their platforms? Something like virtio or >>>> rpmsg doesn't work? >>> >>> +Cc Greg, >>> >>> I doubt they care. This is some stub-driver to pass messages from >>> user-space to the firmware. The interface is undocumented, without >>> examples and no user-space user. >> >> Great, no user? Let's delete the code then :) >> > [Varun] We do have middleware applications that utilize the driver. > Following > are the links: > https://github.com/nxp-imx/imx-secure-enclave > https://github.com/nxp-imx/imx-smw > Why this is not explained in the cover letter and in the patch adding the interfaces? You still need to document and explain the interface. Best regards, Krzysztof