* [PATCH v2] ARM: dts: qcom: ipq4019: correct SDHCI XO clock
@ 2023-08-11 11:01 Robert Marko
2023-08-11 11:48 ` Konrad Dybcio
2023-08-14 2:02 ` Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: Robert Marko @ 2023-08-11 11:01 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt,
conor+dt, linux-arm-msm, devicetree, linux-kernel
Cc: luka.perkov, Robert Marko
Using GCC_DCD_XO_CLK as the XO clock for SDHCI controller is not correct,
it seems that I somehow made a mistake of passing it instead of the fixed
XO clock.
Fixes: 04b3b72b5b8f ("ARM: dts: qcom: ipq4019: Add SDHCI controller node")
Signed-off-by: Robert Marko <robert.marko@sartura.hr>
---
Changes in v2:
* Make clocks and clock-names one-per-line
---
arch/arm/boot/dts/qcom/qcom-ipq4019.dtsi | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/qcom/qcom-ipq4019.dtsi b/arch/arm/boot/dts/qcom/qcom-ipq4019.dtsi
index 5492aeed14a5..80c04915f0e8 100644
--- a/arch/arm/boot/dts/qcom/qcom-ipq4019.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-ipq4019.dtsi
@@ -231,9 +231,12 @@ sdhci: mmc@7824900 {
interrupts = <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 138 IRQ_TYPE_LEVEL_HIGH>;
interrupt-names = "hc_irq", "pwr_irq";
bus-width = <8>;
- clocks = <&gcc GCC_SDCC1_AHB_CLK>, <&gcc GCC_SDCC1_APPS_CLK>,
- <&gcc GCC_DCD_XO_CLK>;
- clock-names = "iface", "core", "xo";
+ clocks = <&gcc GCC_SDCC1_AHB_CLK>,
+ <&gcc GCC_SDCC1_APPS_CLK>,
+ <&xo>;
+ clock-names = "iface",
+ "core",
+ "xo";
status = "disabled";
};
--
2.41.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] ARM: dts: qcom: ipq4019: correct SDHCI XO clock
2023-08-11 11:01 [PATCH v2] ARM: dts: qcom: ipq4019: correct SDHCI XO clock Robert Marko
@ 2023-08-11 11:48 ` Konrad Dybcio
2023-08-14 2:02 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2023-08-11 11:48 UTC (permalink / raw)
To: Robert Marko, agross, andersson, robh+dt, krzysztof.kozlowski+dt,
conor+dt, linux-arm-msm, devicetree, linux-kernel
Cc: luka.perkov
On 11.08.2023 13:01, Robert Marko wrote:
> Using GCC_DCD_XO_CLK as the XO clock for SDHCI controller is not correct,
> it seems that I somehow made a mistake of passing it instead of the fixed
> XO clock.
>
> Fixes: 04b3b72b5b8f ("ARM: dts: qcom: ipq4019: Add SDHCI controller node")
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> ---
Thanks!
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] ARM: dts: qcom: ipq4019: correct SDHCI XO clock
2023-08-11 11:01 [PATCH v2] ARM: dts: qcom: ipq4019: correct SDHCI XO clock Robert Marko
2023-08-11 11:48 ` Konrad Dybcio
@ 2023-08-14 2:02 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2023-08-14 2:02 UTC (permalink / raw)
To: agross, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt, conor+dt,
linux-arm-msm, devicetree, linux-kernel, Robert Marko
Cc: luka.perkov
On Fri, 11 Aug 2023 13:01:16 +0200, Robert Marko wrote:
> Using GCC_DCD_XO_CLK as the XO clock for SDHCI controller is not correct,
> it seems that I somehow made a mistake of passing it instead of the fixed
> XO clock.
>
>
Applied, thanks!
[1/1] ARM: dts: qcom: ipq4019: correct SDHCI XO clock
commit: b5ed7a5c1fdb3981713f7b637b72aa390c3db036
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-14 2:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-11 11:01 [PATCH v2] ARM: dts: qcom: ipq4019: correct SDHCI XO clock Robert Marko
2023-08-11 11:48 ` Konrad Dybcio
2023-08-14 2:02 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).