From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Johan Jonker <jbx6244@gmail.com>,
heiko@sntech.de, zhangqing@rock-chips.com
Cc: robh+dt@kernel.org, krzk+dt@kernel.org, mturquette@baylibre.com,
sboyd@kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 13/16] arm64: dts: rockchip: fix compatible string rk3328 cru node
Date: Sat, 2 Apr 2022 18:53:31 +0200 [thread overview]
Message-ID: <9fab978d-d24f-575b-959b-acfe05c5c4f3@linaro.org> (raw)
In-Reply-To: <20220402143636.15222-14-jbx6244@gmail.com>
On 02/04/2022 16:36, Johan Jonker wrote:
> The rockchip,rk3328-cru.txt file was converted to YAML.
> A DT test of the rk3328 cru node gives notifications regarding
> the compatible string. Bring it in line with the binding by
> removing some unused fall back strings.
I explained to you on your v1, syscon is not a fallback compatible.
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> ---
> arch/arm64/boot/dts/rockchip/rk3328.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> index 9c76c288b..8ceac0388 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> @@ -756,7 +756,7 @@
> };
>
> cru: clock-controller@ff440000 {
> - compatible = "rockchip,rk3328-cru", "rockchip,cru", "syscon";
Please do not resend the same patch without changes and without
finishing the discussion. This looks wrong (and external references you
gave support this). What does this resend means? Discussion is over?
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-04-02 16:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-02 14:36 [PATCH v4 00/16] Convert Rockchip clk Johan Jonker
2022-04-02 14:36 ` [PATCH v4 01/16] dt-bindings: clock: convert rockchip,px30-cru.txt to YAML Johan Jonker
2022-04-02 14:36 ` [PATCH v4 02/16] dt-bindings: clock: convert rockchip,rk3036-cru.txt " Johan Jonker
2022-04-02 14:36 ` [PATCH v4 03/16] dt-bindings: clock: convert rockchip,rk3188-cru.txt " Johan Jonker
2022-04-02 14:36 ` [PATCH v4 04/16] dt-bindings: clock: convert rockchip,rk3228-cru.txt " Johan Jonker
2022-04-02 14:36 ` [PATCH v4 05/16] dt-bindings: clock: convert rockchip,rk3288-cru.txt " Johan Jonker
2022-04-02 14:36 ` [PATCH v4 06/16] dt-bindings: clock: convert rockchip,rk3308-cru.txt " Johan Jonker
2022-04-02 14:36 ` [PATCH v4 07/16] dt-bindings: clock: convert rockchip,rk3328-cru.txt " Johan Jonker
2022-04-02 14:36 ` [PATCH v4 08/16] dt-bindings: clock: convert rockchip,rk3368-cru.txt " Johan Jonker
2022-04-02 14:36 ` [PATCH v4 09/16] dt-bindings: clock: convert rockchip,rv1108-cru.txt " Johan Jonker
2022-04-02 14:36 ` [PATCH v4 10/16] ARM: dts: rockchip: add clocks property to Rockchip cru nodes Johan Jonker
2022-04-02 14:36 ` [PATCH v4 11/16] arm64: " Johan Jonker
2022-04-02 14:36 ` [PATCH v4 12/16] arm64: dts: rockchip: rk3399: use generic node name for pmucru Johan Jonker
2022-04-02 14:36 ` [PATCH v4 13/16] arm64: dts: rockchip: fix compatible string rk3328 cru node Johan Jonker
2022-04-02 16:53 ` Krzysztof Kozlowski [this message]
2022-04-02 14:36 ` [PATCH v4 14/16] dt-bindings: clock: replace a maintainer for rockchip,rk3399-cru.yaml Johan Jonker
2022-04-02 14:36 ` [PATCH v4 15/16] dt-bindings: clock: use generic node name for pmucru example in rockchip,rk3399-cru.yaml Johan Jonker
2022-04-02 16:55 ` Krzysztof Kozlowski
2022-04-02 14:36 ` [PATCH v4 16/16] dt-bindings: clock: fix some conversion clock issues for rockchip,rk3399-cru.yaml Johan Jonker
2022-04-02 16:45 ` [PATCH v4 00/16] Convert Rockchip clk Krzysztof Kozlowski
2022-04-02 16:59 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fab978d-d24f-575b-959b-acfe05c5c4f3@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=zhangqing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).