devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Rafał Miłecki" <zajec5@gmail.com>
To: Lee Jones <lee@kernel.org>
Cc: "Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Pavel Machek" <pavel@ucw.cz>,
	"Jacek Anaszewski" <jacek.anaszewski@gmail.com>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	devicetree@vger.kernel.org, linux-leds@vger.kernel.org,
	"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH V2 REBASED] dt-bindings: leds: add "usbport" trigger
Date: Thu, 28 Dec 2023 08:33:00 +0100	[thread overview]
Message-ID: <9fe9cf5b-c215-4538-b726-abe61ea01e4a@gmail.com> (raw)
In-Reply-To: <20230316153310.GI9667@google.com>

Hi Lee,

On 16.03.2023 16:33, Lee Jones wrote:
> On Thu, 16 Mar 2023, Rafał Miłecki wrote:
> 
>> From: Rafał Miłecki <rafal@milecki.pl>
>>
>> Linux's "usbport" trigger is a bit specific one. It allows LED to follow
>> state of multiple USB ports which have to be selected additionally
>> (there isn't a single trigger for each port).
>>
>> Default list of USB ports to monitor can be specified using
>> "trigger-sources" DT property. Theoretically it should be possible for
>> Linux to deduce applicable trigger based on the references nodes in the
>> "trigger-sources". It hasn't been implemented however (probably due to
>> laziness).
>>
>> Milk spilled - we already have DT files specifying "usbport" manually -
>> allow that value in the binding. This fixes validation of in-kernel and
>> external DT files.
>>
>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
>> ---
>>   Documentation/devicetree/bindings/leds/common.yaml | 2 ++
>>   1 file changed, 2 insertions(+)
> 
> Applied, thanks

it seems this PATCH got lost somewhere. Can you check it, please?

-- 
Rafał Miłecki

  reply	other threads:[~2023-12-28  7:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-16 13:55 [PATCH V2 REBASED] dt-bindings: leds: add "usbport" trigger Rafał Miłecki
2023-03-16 15:33 ` Lee Jones
2023-12-28  7:33   ` Rafał Miłecki [this message]
2024-01-09  8:42     ` Lee Jones
2024-01-09 10:05       ` Rafał Miłecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9fe9cf5b-c215-4538-b726-abe61ea01e4a@gmail.com \
    --to=zajec5@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=jacek.anaszewski@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lee@kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rafal@milecki.pl \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).