Re: [PATCH 1/3] arm/dt: add basic mx51 device tree support

[Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>]

Hi Jason,

On 18 February 2011 16:12, Jason Liu <r64343-KZfg59tc24xl57MIdRCFDg@public.gmane.org> wrote:
> Signed-off-by: Jason Liu <r64343-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> ---
>  arch/arm/mach-mx5/Kconfig               |    6 +++
>  arch/arm/mach-mx5/Makefile              |    1 +
>  arch/arm/mach-mx5/board-dt.c            |   64 +++++++++++++++++++++++++++++++
>  arch/arm/mach-mx5/clock-mx51-mx53.c     |   45 +++++++++++++++++++++-
>  arch/arm/plat-mxc/include/mach/common.h |    1 +
>  5 files changed, 116 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-mx5/Kconfig b/arch/arm/mach-mx5/Kconfig
> index de4fa99..5fbbd36 100644
> --- a/arch/arm/mach-mx5/Kconfig
> +++ b/arch/arm/mach-mx5/Kconfig
> @@ -47,6 +47,12 @@ config MACH_MX51_BABBAGE
>          u-boot. This includes specific configurations for the board and its
>          peripherals.
>
> +config MACH_MX51_DT
> +       bool "Generic MX51 board (FDT support)"
> +       select USE_OF
> +       help
> +         Support for generic Freescale MX51 boards using Flattened Device Tree.
> +

We may at least need to select SOC_IMX51 here, otherwise it does not
even build if MACH_MX51_DT is the only machine being selected (e.g.
none of any other mx51 machine being selected together).

And tab is being used throughout the file for indentation, but you
are using spaces here.

>  config MACH_MX51_3DS
>        bool "Support MX51PDK (3DS)"
>        select SOC_IMX51

-- 
Regards,
Shawn