From: Grant Likely <grant.likely@secretlab.ca>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: devicetree-discuss@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] spi: mpc52xx_psc_spi: fix section mismatch warning
Date: Thu, 16 Dec 2010 10:23:40 -0700 [thread overview]
Message-ID: <AANLkTi=hKvEDd7+e9hoFxF-VP-Fy648OEX7ha1gBLkKz@mail.gmail.com> (raw)
In-Reply-To: <1292519639-21859-3-git-send-email-w.sang@pengutronix.de>
On Thu, Dec 16, 2010 at 10:13 AM, Wolfram Sang <w.sang@pengutronix.de> wrote:
> Done by using of_probe_platform_driver() instead of
> of_register_platform_driver().
>
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Move the probe hook to the __devinit section instead.
g.
> ---
> drivers/spi/mpc52xx_psc_spi.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/spi/mpc52xx_psc_spi.c b/drivers/spi/mpc52xx_psc_spi.c
> index 983fbbf..4bf6d37 100644
> --- a/drivers/spi/mpc52xx_psc_spi.c
> +++ b/drivers/spi/mpc52xx_psc_spi.c
> @@ -509,7 +509,6 @@ static const struct of_device_id mpc52xx_psc_spi_of_match[] = {
> MODULE_DEVICE_TABLE(of, mpc52xx_psc_spi_of_match);
>
> static struct of_platform_driver mpc52xx_psc_spi_of_driver = {
> - .probe = mpc52xx_psc_spi_of_probe,
> .remove = __exit_p(mpc52xx_psc_spi_of_remove),
> .driver = {
> .name = "mpc52xx-psc-spi",
> @@ -520,7 +519,8 @@ static struct of_platform_driver mpc52xx_psc_spi_of_driver = {
>
> static int __init mpc52xx_psc_spi_init(void)
> {
> - return of_register_platform_driver(&mpc52xx_psc_spi_of_driver);
> + return of_probe_platform_driver(&mpc52xx_psc_spi_of_driver,
> + mpc52xx_psc_spi_of_probe);
> }
> module_init(mpc52xx_psc_spi_init);
>
> --
> 1.7.2.3
>
>
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2010-12-16 17:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-16 17:13 [RFC 0/3] Introduce of_probe_platform_driver() Wolfram Sang
[not found] ` <1292519639-21859-1-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-12-16 17:13 ` [PATCH 1/3] of: platform: introduce of_probe_platform_driver() Wolfram Sang
[not found] ` <1292519639-21859-2-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-12-16 17:22 ` Grant Likely
[not found] ` <AANLkTimxAGVkQF24YgDt+TxjbXvW+iCNJhqVLwXO6FXD-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-12-16 18:26 ` Wolfram Sang
2010-12-16 17:13 ` [PATCH 2/3] spi: mpc52xx_psc_spi: fix section mismatch warning Wolfram Sang
2010-12-16 17:23 ` Grant Likely [this message]
2010-12-16 17:13 ` [PATCH 3/3] spi: mpc512x_psc_spi: move probe-routine to __init Wolfram Sang
2010-12-16 17:27 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=hKvEDd7+e9hoFxF-VP-Fy648OEX7ha1gBLkKz@mail.gmail.com' \
--to=grant.likely@secretlab.ca \
--cc=devicetree-discuss@ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).