From: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
To: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linaro-dev-cunTk1MwBs8s++Sfvej+rw@public.gmane.org,
patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH 0/5] make sdhci device drivers self registered
Date: Mon, 21 Mar 2011 00:58:49 -0600 [thread overview]
Message-ID: <AANLkTimrJ3=GS-+o1vcBpMXg0Phwnu9SVgm0WA-Ck_sf@mail.gmail.com> (raw)
In-Reply-To: <1300678938-8046-1-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
On Sun, Mar 20, 2011 at 9:42 PM, Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
> This patch set is to take sdhci device driver specific things out
> from sdhci-pltfm.c and make them self registered. Here are the
> difference it makes.
>
> * Get the sdhci device driver follow the Linux trend that driver
> take the registration by its own
> * sdhci-pltfm.c becomes significantly simpler and only has common
> support functions there
> * All sdhci device specific stuff are going back its own driver
> * The dt and non-dt support share the same pair of .probe and
> .remove hooks.
Fantastic! Thanks for taking this on. I'll make a few comments, but
this series really needs to be reposted to both the linux-kernel and
linux-mmc lists.
g.
>
> The first one patch adds common support function into sdhci-pltfm.c
> when changing sdhci-esdhc-imx driver, while the last one clean up
> sdhci-pltfm.c when changing sdhci-tegra driver.
>
> Only the patch of sdhci-esdhc-imx are tested on hardware, and others
> are just build tested.
>
> Regards,
> Shawn
>
> Shawn Guo (5):
> mmc: sdhci: make sdhci-esdhc-imx driver self registered
> mmc: sdhci: make sdhci-cns3xxx driver self registered
> mmc: sdhci: make sdhci-dove driver self registered
> mmc: sdhci: make sdhci-tegra driver self registered
> mmc: sdhci: update Makefile/Kconfig for sdhci_pltfm change
>
> drivers/mmc/host/Kconfig | 24 +++--
> drivers/mmc/host/Makefile | 11 +-
> drivers/mmc/host/sdhci-cns3xxx.c | 68 +++++++++++++-
> drivers/mmc/host/sdhci-dove.c | 70 +++++++++++++-
> drivers/mmc/host/sdhci-esdhc-imx.c | 98 +++++++++++++++----
> drivers/mmc/host/sdhci-pltfm.c | 165 ++-----------------------------
> drivers/mmc/host/sdhci-pltfm.h | 14 ++-
> drivers/mmc/host/sdhci-tegra.c | 189 +++++++++++++++++++++---------------
>
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2011-03-21 6:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-21 3:42 [PATCH 0/5] make sdhci device drivers self registered Shawn Guo
[not found] ` <1300678938-8046-1-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-03-21 3:42 ` [PATCH 1/5] mmc: sdhci: make sdhci-esdhc-imx driver " Shawn Guo
2011-03-21 3:42 ` [PATCH 2/5] mmc: sdhci: make sdhci-cns3xxx " Shawn Guo
2011-03-21 3:42 ` [PATCH 3/5] mmc: sdhci: make sdhci-dove " Shawn Guo
2011-03-21 3:42 ` [PATCH 4/5] mmc: sdhci: make sdhci-tegra " Shawn Guo
2011-03-21 3:42 ` [PATCH 5/5] mmc: sdhci: update Makefile/Kconfig for sdhci_pltfm change Shawn Guo
2011-03-21 6:58 ` Grant Likely [this message]
[not found] ` <AANLkTimrJ3=GS-+o1vcBpMXg0Phwnu9SVgm0WA-Ck_sf-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-03-21 7:07 ` [PATCH 0/5] make sdhci device drivers self registered Grant Likely
-- strict thread matches above, loose matches on Subject: below --
2011-03-21 8:06 Shawn Guo
[not found] ` <1300694823-8300-1-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-03-21 12:39 ` Arnd Bergmann
[not found] ` <201103211339.45305.arnd-r2nGTMty4D4@public.gmane.org>
2011-03-21 12:52 ` Shawn Guo
2011-03-21 12:54 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTimrJ3=GS-+o1vcBpMXg0Phwnu9SVgm0WA-Ck_sf@mail.gmail.com' \
--to=grant.likely-s3s/wqlpoipyb63q8fvjnq@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=linaro-dev-cunTk1MwBs8s++Sfvej+rw@public.gmane.org \
--cc=patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).