From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stijn Devriendt Subject: Re: [PATCH 1/3] misc: at24: parse OF-data, too Date: Mon, 22 Nov 2010 17:48:40 +0100 Message-ID: References: <1289995250-17927-1-git-send-email-w.sang@pengutronix.de> <1289995250-17927-2-git-send-email-w.sang@pengutronix.de> <5F1D4949966C4C509360407B0F948EFE@HIGHGuY> <20101120124226.GB11936@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20101120124226.GB11936@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org To: Wolfram Sang Cc: linuxppc-dev@ozlabs.org, devicetree-discuss@ozlabs.org List-Id: devicetree@vger.kernel.org Hi Wolfram, I seem to be mistaken. I retried "compatible=3D" and it did all the right things. I was mistaken that request_module() only takes the driver name, at24 in this case, and not all device names in the table_ids. This pretty much makes my patch redundant. Thanks for helping me clear things out. Regards, Stijn On Sat, Nov 20, 2010 at 1:42 PM, Wolfram Sang wrote: > Hi, > >> As far as I could tell, using compatible =3D <24c64>; didn't load the ri= ght >> module (module name is at24) and using at24 caused a device id mismatch >> because at24 is not a known device ID. I could be wrong here and if so, = I'd >> very =A0much like a source code hint as to why... > > Have you tried ", 24c64"? All I can say is that it works for me. = Plain > at24 worked for years with pcm030.dts and pcm032.dts, so I don't know whi= ch > issue you are facing. This patch is just about extending the support. > >> My patch worked by changing drivers/of/of_i2c.c to allow a generic >> kind =3D " " statement that was filled in as i2c_board_info.type, to all= ow >> the module name and the device id to be different. >> This makes the at24 driver no longer rely on probing (which it claims >> is buggy anyway) and also benefits other drivers that support multiple >> devices, but where probing is difficult (e.g. lm90 driver). >> >> I'm in the process of getting employer approval to get these patches >> upstream. > > I hope you will get it approved, it is a lot easier to talk about code :) > > Best regards, > > =A0 Wolfram > > -- > Pengutronix e.K. =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 | Wo= lfram Sang =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0| > Industrial Linux Solutions =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 | http://www.p= engutronix.de/ =A0| > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.9 (GNU/Linux) > > iEYEARECAAYFAkznwjIACgkQD27XaX1/VRssnwCgg55UCwZFLcMI8kJI3mhCJQxL > N7kAoJHpLn5BJpNjET+ngaQFrGxUBQm1 > =3DtyTb > -----END PGP SIGNATURE----- > >