From: Lv Zheng <lv.zheng@linux.spacemit.com>
To: Conor Dooley <conor@kernel.org>
Cc: Conor Dooley <conor.dooley@microchip.com>,
Tomasz Jeznach <tjeznach@rivosinc.com>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
James Clark <james.clark@linaro.org>, Yixun Lan <dlan@kernel.org>,
Jingyu Li <joey.li@spacemit.com>, Zong Li <zong.li@sifive.com>,
Yaxing Guo <guoyaxing@bosc.ac.cn>,
iommu@lists.linux.dev, linux-perf-users@vger.kernel.org,
linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 4/8] dt-bindings: iommu: Add spacemit/t100 features
Date: Mon, 2 Mar 2026 09:41:55 +0800 [thread overview]
Message-ID: <B8675026D2F6DF58+946ff82a-2e2e-4abb-a3c4-26fe67c43ab8@linux.spacemit.com> (raw)
In-Reply-To: <20260301-acclimate-suburb-fc46da7e0cea@spud>
On 3/1/2026 10:01 PM, Conor Dooley wrote:
> On Sun, Mar 01, 2026 at 11:48:37AM +0800, Lv Zheng wrote:
>> On 3/1/2026 5:58 AM, Conor Dooley wrote:
>>> On Sat, 28 Feb 2026 22:44:49 +0800, Lv Zheng <lv.zheng@linux.spacemit.com> wrote:
>>>> Adds device tree bindings for SpacemiT T100 specific features by
>>>> introducing spacemit,t100 compatible. T100 contains distributed IOATCs,
>>>> each of which exposes pmiv interrupt.
>>>>
>>>> Signed-off-by: Lv Zheng <lv.zheng@linux.spacemit.com>
>>>> Signed-off-by: Jingyu Li <joey.li@spacemit.com>
>>>
>>> Patch content here is fine, but the signoff chain on this patch is not
>>> right. What did Jingyu do? You're author and submitter so either Jingyu
>>> did nothing and should be removed, or is a co-developer which requires
>>> attribution via the co-developed-by tag. If the latter, their signoff
>>> should be before yours (the submitter is always last).
>>>
>>> pw-bot: changes-requested
>>
>> She is responsible for the common HPM part, and I just gave my comments to
>> help to improve the quality of that implementation.
>> I was just focusing on enabling and maintaining the T100 specific features.
>>
>> Our patches will go each other's local repository, leaving such tracks. That
>> means the patch from me is Reviewed-and-tested-by her.
>> And I'm responsible for sending the whole patchset for upstreaming.
>
> Then you need to either fix your email setup (because it's not inserting
> From: Jingyu Li <joey.li@spacemit.com>) so that she is marked as the
> author or actually set her to the author in git if you haven't.
> Currently it looks like this when applied:
> commit 872978c875731be43e84bec38798cb8ecd42b7a0
> Author: Lv Zheng <lv.zheng@linux.spacemit.com>
> Date: Sat Feb 28 22:44:49 2026 +0800
>
> dt-bindings: iommu: Add spacemit/t100 features
>
> Adds device tree bindings for SpacemiT T100 specific features by
> introducing spacemit,t100 compatible. T100 contains distributed IOATCs,
> each of which exposes pmiv interrupt.
>
> Signed-off-by: Lv Zheng <lv.zheng@linux.spacemit.com>
> Signed-off-by: Jingyu Li <joey.li@spacemit.com>
>
> In both cases, you need to change the order of signoffs so that yours is
> last as the submitter.
OK.
BTW, since this version of this patch has been worked out all due your
constructive feedback and suggestions. Now that it has functionally
converged to what the community requested, can I add "Reviewed-by: Conor
Dooley <conor@kernel.org>" for its next version?
Best regards,
Lv
next prev parent reply other threads:[~2026-03-02 1:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1772289741.git.lv.zheng@linux.spacemit.com>
2026-02-28 14:44 ` [PATCH v5 1/8] iommu/riscv: Enable IOMMU DMA mapping support Lv Zheng
2026-02-28 14:44 ` [PATCH v5 2/8] iommu/riscv: Add auxiliary bus framework and HPM device support Lv Zheng
2026-02-28 14:44 ` [PATCH v5 3/8] iommu/riscv: Add HPM support for performance monitoring Lv Zheng
2026-02-28 14:44 ` [PATCH v5 4/8] dt-bindings: iommu: Add spacemit/t100 features Lv Zheng
2026-02-28 21:58 ` Conor Dooley
2026-03-01 3:48 ` Lv Zheng
2026-03-01 14:01 ` Conor Dooley
2026-03-02 1:41 ` Lv Zheng [this message]
2026-03-02 17:53 ` Conor Dooley
2026-02-28 14:44 ` [PATCH v5 5/8] spacemit/t100: Add global filter awareness for RISC-V IOMMU HPM Lv Zheng
2026-02-28 14:45 ` [PATCH v5 6/8] iommu/riscv: Add SpacemiT T100 IOATC HPM support Lv Zheng
2026-02-28 14:45 ` [PATCH v5 7/8] iommu/riscv: Add vendor event support for RISC-V IOMMU HPM Lv Zheng
2026-02-28 14:45 ` [PATCH v5 8/8] perf vendor events riscv: Add SpacemiT T100 HPM event aliases Lv Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B8675026D2F6DF58+946ff82a-2e2e-4abb-a3c4-26fe67c43ab8@linux.spacemit.com \
--to=lv.zheng@linux.spacemit.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alex@ghiti.fr \
--cc=alexander.shishkin@linux.intel.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlan@kernel.org \
--cc=guoyaxing@bosc.ac.cn \
--cc=iommu@lists.linux.dev \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=joey.li@spacemit.com \
--cc=jolsa@kernel.org \
--cc=joro@8bytes.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=palmer@dabbelt.com \
--cc=peterz@infradead.org \
--cc=pjw@kernel.org \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=spacemit@lists.linux.dev \
--cc=tjeznach@rivosinc.com \
--cc=will@kernel.org \
--cc=zong.li@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox