From: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
To: Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 3/3] ARM: l2x0: Add OF based initialization
Date: Tue, 7 Jun 2011 09:20:30 -0700 [thread overview]
Message-ID: <BANLkTi=7rHjKV=+hNKzEHvZMeDPwknOWtg@mail.gmail.com> (raw)
In-Reply-To: <1307456541-11026-4-git-send-email-robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Tue, Jun 7, 2011 at 7:22 AM, Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> +- aux-value : Value to set the Auxillary Control register to. Setting masked
> + bits is undefined. Default value is 0.
> +- aux-mask : Mask of bits to preserve in the Auxillary Control register.
> + Default value is 0xffffffff.
The device tree should describe the hardware, not the way the linux
kernel drives the hardware. In the case of the AUX register, it's
mostly a collection of options that are either turned on or off. I
don't think they should necessarily be described as an opaque 32-bit
word, but instead as separate attributes.
At least the geometry should be specified that way.
For feature enable bits, it depends on what features should be enabled
and from the kernel side. I'm not sure that belongs in the device tree
at all.
-Olof
next prev parent reply other threads:[~2011-06-07 16:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-07 14:22 [PATCH v2 0/3] DT bindings for Cortex A9 peripherals Rob Herring
[not found] ` <1307456541-11026-1-git-send-email-robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-06-07 14:22 ` [PATCH 1/3] ARM: pmu: add OF probing support Rob Herring
2011-06-08 15:54 ` Mark Rutland
[not found] ` <1307456541-11026-2-git-send-email-robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-06-08 15:54 ` Mark Rutland
[not found] ` <000001cc25f4$64c2d5c0$2e488140$@rutland@arm.com>
[not found] ` <000001cc25f4$64c2d5c0$2e488140$@rutland-5wv7dgnIgG8@public.gmane.org>
2011-06-08 16:40 ` Rob Herring
2011-06-13 16:44 ` Grant Likely
2011-06-07 14:22 ` [PATCH 2/3] ARM: gic: add OF based initialization Rob Herring
[not found] ` <1307456541-11026-3-git-send-email-robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-06-13 16:53 ` Grant Likely
[not found] ` <20110613165316.GF18161-e0URQFbLeQY2iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2011-06-13 21:39 ` Rob Herring
2011-06-13 22:14 ` Russell King - ARM Linux
2011-06-14 13:56 ` Grant Likely
2011-06-07 14:22 ` [PATCH 3/3] ARM: l2x0: Add " Rob Herring
[not found] ` <1307456541-11026-4-git-send-email-robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-06-07 16:20 ` Olof Johansson [this message]
[not found] ` <BANLkTi=7rHjKV=+hNKzEHvZMeDPwknOWtg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-06-07 16:54 ` Rob Herring
[not found] ` <4DEE57D7.1030704-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-06-07 18:49 ` Olof Johansson
-- strict thread matches above, loose matches on Subject: below --
2011-06-01 16:37 [PATCH 0/3] DT bindings Cortex A9 peripherals Rob Herring
[not found] ` <1306946270-18379-1-git-send-email-robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-06-01 16:37 ` [PATCH 3/3] ARM: l2x0: Add OF based initialization Rob Herring
[not found] ` <1306946270-18379-4-git-send-email-robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-06-01 18:40 ` Olof Johansson
[not found] ` <BANLkTik86CVS0cWOnapnh7dn5F1EOCsmVw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-06-01 19:01 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=7rHjKV=+hNKzEHvZMeDPwknOWtg@mail.gmail.com' \
--to=olof-nzht3qvonbneowh0uzbu5w@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).