From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olof Johansson Subject: Re: [PATCH 3/3] ARM: l2x0: Add OF based initialization Date: Tue, 7 Jun 2011 09:20:30 -0700 Message-ID: References: <1307456541-11026-1-git-send-email-robherring2@gmail.com> <1307456541-11026-4-git-send-email-robherring2@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1307456541-11026-4-git-send-email-robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Rob Herring Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Tue, Jun 7, 2011 at 7:22 AM, Rob Herring wrote: > +- aux-value : Value to set the Auxillary Control register to. Setting ma= sked > + =A0bits is undefined. Default value is 0. > +- aux-mask : Mask of bits to preserve in the Auxillary Control register. > + =A0Default value is 0xffffffff. The device tree should describe the hardware, not the way the linux kernel drives the hardware. In the case of the AUX register, it's mostly a collection of options that are either turned on or off. I don't think they should necessarily be described as an opaque 32-bit word, but instead as separate attributes. At least the geometry should be specified that way. For feature enable bits, it depends on what features should be enabled and from the kernel side. I'm not sure that belongs in the device tree at all. -Olof