Re: [PATCH v5] uio/pdrv_genirq: Add OF support

[Thomas De Schampheleire <patrickdepinguin+devicetree-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1846 bytes --]

Hi,

On Fri, May 6, 2011 at 2:47 AM, Hans J. Koch <hjk-vqZO0P4V72/QD6PfKP4TzA@public.gmane.org> wrote:

> On Thu, May 05, 2011 at 08:40:44AM +0200, Michal Simek wrote:
>
> I think we've got it.
>
> Thanks,
> Hans
>
> > Adding OF binding to genirq.
> > Version string is setup to the "devicetree".
> >
> > Compatible string is not setup for now but you can add your
> > custom compatible string to uio_of_genirq_match structure.
> >
> > For example with "vendor,device" compatible string:
> > static const struct of_device_id __devinitconst uio_of_genirq_match[] = {
> >       { .compatible = "vendor,device", },
> >       { /* empty for now */ },
> > };
> >
> > Signed-off-by: Michal Simek <monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org>
>
> Signed-off-by: Hans J. Koch <hjk-vqZO0P4V72/QD6PfKP4TzA@public.gmane.org>
>
> > CC: Hans J. Koch <hjk-vqZO0P4V72/QD6PfKP4TzA@public.gmane.org>
> > CC: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
> > CC: John Williams <john.williams-g5w7nrANp4BDPfheJLI6IQ@public.gmane.org>
> > CC: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
> > CC: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> >
>

Sorry for adding to this discussion so late...

I fail to see how a device described in the device tree can be bound to this
generic driver, as the match table is empty. I read in the description:


> Compatible string is not setup for now but you can add your
> custom compatible string to uio_of_genirq_match structure.
>
> For example with "vendor,device" compatible string:
> static const struct of_device_id __devinitconst uio_of_genirq_match[] = {
>       { .compatible = "vendor,device", },
>       { /* empty for now */ },
> };

So, this would mean that for a given project, you need to modify the sources
of the *generic* driver ?

Thanks for clarifying,
Thomas

[-- Attachment #1.2: Type: text/html, Size: 2932 bytes --]

[-- Attachment #2: Type: text/plain, Size: 192 bytes --]

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss