From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas De Schampheleire Subject: Re: [PATCH v5] uio/pdrv_genirq: Add OF support Date: Thu, 12 May 2011 15:56:37 +0200 Message-ID: References: <1304577644-4024-1-git-send-email-monstr@monstr.eu> <20110506004748.GB2790@local> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7602181680051439727==" Return-path: In-Reply-To: <20110506004748.GB2790@local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: "Hans J. Koch" , Michal Simek Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, John Williams List-Id: devicetree@vger.kernel.org --===============7602181680051439727== Content-Type: multipart/alternative; boundary=0015175cdfe4ce62e104a3148eb9 --0015175cdfe4ce62e104a3148eb9 Content-Type: text/plain; charset=ISO-8859-1 Hi, On Fri, May 6, 2011 at 2:47 AM, Hans J. Koch wrote: > On Thu, May 05, 2011 at 08:40:44AM +0200, Michal Simek wrote: > > I think we've got it. > > Thanks, > Hans > > > Adding OF binding to genirq. > > Version string is setup to the "devicetree". > > > > Compatible string is not setup for now but you can add your > > custom compatible string to uio_of_genirq_match structure. > > > > For example with "vendor,device" compatible string: > > static const struct of_device_id __devinitconst uio_of_genirq_match[] = { > > { .compatible = "vendor,device", }, > > { /* empty for now */ }, > > }; > > > > Signed-off-by: Michal Simek > > Signed-off-by: Hans J. Koch > > > CC: Hans J. Koch > > CC: Arnd Bergmann > > CC: John Williams > > CC: Grant Likely > > CC: Wolfram Sang > > > Sorry for adding to this discussion so late... I fail to see how a device described in the device tree can be bound to this generic driver, as the match table is empty. I read in the description: > Compatible string is not setup for now but you can add your > custom compatible string to uio_of_genirq_match structure. > > For example with "vendor,device" compatible string: > static const struct of_device_id __devinitconst uio_of_genirq_match[] = { > { .compatible = "vendor,device", }, > { /* empty for now */ }, > }; So, this would mean that for a given project, you need to modify the sources of the *generic* driver ? Thanks for clarifying, Thomas --0015175cdfe4ce62e104a3148eb9 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hi,

On Fri, May 6, 2011 at 2:47 AM, Hans = J. Koch <hjk@hansj= koch.de> wrote:
On Thu, May 05, 2011 at 08:40:44AM +0200, Michal Simek wrote:

I think we've got it.

Thanks,
Hans

> Adding OF binding to genirq.
> Version string is setup to the "devicetree".
>
> Compatible string is not setup for now but you can add your
> custom compatible string to uio_of_genirq_match structure.
>
> For example with "vendor,device" compatible string:
> static const struct of_device_id __devinitconst uio_of_genirq_match[] = =3D {
> =A0 =A0 =A0 { .compatible =3D "vendor,device", },
> =A0 =A0 =A0 { /* empty for now */ },
> };
>
> Signed-off-by: Michal Simek <mo= nstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org>

Signed-off-by: Hans J. Koch <h= jk-vqZO0P4V72/QD6PfKP4TzA@public.gmane.org>

Sorry for adding to this discussi= on so late...

I fail to see how a device described in the device tree can be bound to this generic=20 driver, as the match table is empty. I read in the description:


> Compatible string is not setup for now but you can add your
> custom compatible string to uio_of_genirq_match structure.
>
> For example with "vendor,device" compatible string:
> static const struct of_device_id __devinitconst uio_of_genirq_match[] = =3D {
> =A0 =A0 =A0 { .compatible =3D "vendor,device", },
> =A0 =A0 =A0 { /* empty for now */ },
> };

So, this would mean that for a given project, you need= to modify the sources of the *generic* driver ?

Thanks for clarifyi= ng,
Thomas

--0015175cdfe4ce62e104a3148eb9-- --===============7602181680051439727== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ devicetree-discuss mailing list devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org https://lists.ozlabs.org/listinfo/devicetree-discuss --===============7602181680051439727==--