DTC failure on /memreserve/ if moved after /include/

DTC failure on /memreserve/ if moved after /include/

[Stephen Warren]

The following from tegra-harmony.dts compiles fine:

    /dts-v1/;

    /memreserve/ 0x1c000000 0x04000000;
    /include/ "tegra250.dts"

    / {

However, if I re-order this as follows:

    /dts-v1/;
    /include/ "tegra250.dts"

    /memreserve/ 0x1c000000 0x04000000;

    / {

Then dtc fails:

      DTC     arch/arm/boot/tegra-harmony.dtb
    DTC: dts->dtb  on file "arch/arm/boot/dts/tegra-harmony.dts"
    Error: arch/arm/boot/dts/tegra-harmony.dts:4.1-13 syntax error
    FATAL ERROR: Unable to parse input tree
    make[1]: *** [arch/arm/boot/tegra-harmony.dtb] Error 1

Is this a dtc bug, or does the DTS syntax actually disallow this?

Thanks.

-- 
nvpublic

Re: DTC failure on /memreserve/ if moved after /include/

[Grant Likely]

cc'ing David Gibson and Jon Loeliger who both can do a better job of
answering this question.

g.


On Mon, May 2, 2011 at 12:54 PM, Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> wrote:
> The following from tegra-harmony.dts compiles fine:
>
>    /dts-v1/;
>
>    /memreserve/ 0x1c000000 0x04000000;
>    /include/ "tegra250.dts"
>
>    / {
>
> However, if I re-order this as follows:
>
>    /dts-v1/;
>    /include/ "tegra250.dts"
>
>    /memreserve/ 0x1c000000 0x04000000;
>
>    / {
>
> Then dtc fails:
>
>      DTC     arch/arm/boot/tegra-harmony.dtb
>    DTC: dts->dtb  on file "arch/arm/boot/dts/tegra-harmony.dts"
>    Error: arch/arm/boot/dts/tegra-harmony.dts:4.1-13 syntax error
>    FATAL ERROR: Unable to parse input tree
>    make[1]: *** [arch/arm/boot/tegra-harmony.dtb] Error 1
>
> Is this a dtc bug, or does the DTS syntax actually disallow this?
>
> Thanks.
>
> --
> nvpublic
>
> _______________________________________________
> devicetree-discuss mailing list
> devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
> https://lists.ozlabs.org/listinfo/devicetree-discuss
>



-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

Re: DTC failure on /memreserve/ if moved after /include/

[Jon Loeliger]

> The following from tegra-harmony.dts compiles fine:
> 
>     /dts-v1/;
> 
>     /memreserve/ 0x1c000000 0x04000000;
>     /include/ "tegra250.dts"
> 
>     / {
> 
> However, if I re-order this as follows:
> 
>     /dts-v1/;
>     /include/ "tegra250.dts"
> 
>     /memreserve/ 0x1c000000 0x04000000;
> 
>     / {
> 
> Then dtc fails:
>
> Is this a dtc bug, or does the DTS syntax actually disallow this?


Correct.  The grammar is explicitly:

    sourcefile:
	      DT_V1 ';' memreserves devicetree
	    ;

    memreserves:
	      /* empty */
	    | memreserve memreserves
	    ;

    memreserve:
	      DT_MEMRESERVE addr addr ';'


and then much later devicetree leads to...:


    propdata:
	      propdataprefix DT_STRING
	    | propdataprefix '<' celllist '>'
	    | propdataprefix '[' bytestring ']'
	    | propdataprefix DT_REF
	    | propdataprefix DT_INCBIN '(' DT_STRING ',' addr ',' addr ')'

where INCBIN is the include mechanism.

jdl

Re: DTC failure on /memreserve/ if moved after /include/

[David Gibson]

On Mon, May 02, 2011 at 04:06:01PM -0500, Jon Loeliger wrote:
> > The following from tegra-harmony.dts compiles fine:
> > 
> >     /dts-v1/;
> > 
> >     /memreserve/ 0x1c000000 0x04000000;
> >     /include/ "tegra250.dts"
> > 
> >     / {
> > 
> > However, if I re-order this as follows:
> > 
> >     /dts-v1/;
> >     /include/ "tegra250.dts"
> > 
> >     /memreserve/ 0x1c000000 0x04000000;
> > 
> >     / {
> > 
> > Then dtc fails:
> >
> > Is this a dtc bug, or does the DTS syntax actually disallow this?
> 
> 
> Correct.  The grammar is explicitly:
> 
>     sourcefile:
> 	      DT_V1 ';' memreserves devicetree
> 	    ;
> 
>     memreserves:
> 	      /* empty */
> 	    | memreserve memreserves
> 	    ;
> 
>     memreserve:
> 	      DT_MEMRESERVE addr addr ';'
> 
> 
> and then much later devicetree leads to...:
> 
> 
>     propdata:
> 	      propdataprefix DT_STRING
> 	    | propdataprefix '<' celllist '>'
> 	    | propdataprefix '[' bytestring ']'
> 	    | propdataprefix DT_REF
> 	    | propdataprefix DT_INCBIN '(' DT_STRING ',' addr ',' addr ')'
> 
> where INCBIN is the include mechanism.

Uh, no, incbin is different.  /include/ is processed at the lexical
level and can appear in any order.

What matters here is not the /include/ per se, but what appears in the
included file.  I imagine it has some device tree content, and
/memreserve/ can't appear after that.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Re: DTC failure on /memreserve/ if moved after /include/

[Jon Loeliger]

> 
> Uh, no, incbin is different.  /include/ is processed at the lexical
> level and can appear in any order.

Crap.  Got confused.  Sorry.

jdl