devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
To: Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 3/3] ARM: l2x0: Add OF based initialization
Date: Wed, 1 Jun 2011 11:40:56 -0700	[thread overview]
Message-ID: <BANLkTik86CVS0cWOnapnh7dn5F1EOCsmVw@mail.gmail.com> (raw)
In-Reply-To: <1306946270-18379-4-git-send-email-robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

On Wed, Jun 1, 2011 at 9:37 AM, Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> From: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
>
> This adds probing for pl310 cache controller via device tree. An example
> binding looks like this:
>
> L2: l2-cache {
>        compatible = "arm,pl310-cache", "cache";

"cache" is too generic to be useful. "arm,pl2x0-cache" would be a more
meaningful fallback, I think?

(Same comment as for 1/3: The bindings need to be documented. Same
applies to 2/3, obviousy).

-Olof

  parent reply	other threads:[~2011-06-01 18:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-01 16:37 [PATCH 0/3] DT bindings Cortex A9 peripherals Rob Herring
     [not found] ` <1306946270-18379-1-git-send-email-robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-06-01 16:37   ` [PATCH 1/3] ARM: pmu: add OF probing support Rob Herring
     [not found]     ` <1306946270-18379-2-git-send-email-robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-06-01 18:37       ` Olof Johansson
2011-06-01 16:37   ` [PATCH 2/3] ARM: gic: add OF based initialization Rob Herring
2011-06-01 16:37   ` [PATCH 3/3] ARM: l2x0: Add " Rob Herring
     [not found]     ` <1306946270-18379-4-git-send-email-robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-06-01 18:40       ` Olof Johansson [this message]
     [not found]         ` <BANLkTik86CVS0cWOnapnh7dn5F1EOCsmVw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-06-01 19:01           ` Rob Herring
  -- strict thread matches above, loose matches on Subject: below --
2011-06-07 14:22 [PATCH v2 0/3] DT bindings for Cortex A9 peripherals Rob Herring
     [not found] ` <1307456541-11026-1-git-send-email-robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-06-07 14:22   ` [PATCH 3/3] ARM: l2x0: Add OF based initialization Rob Herring
     [not found]     ` <1307456541-11026-4-git-send-email-robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-06-07 16:20       ` Olof Johansson
     [not found]         ` <BANLkTi=7rHjKV=+hNKzEHvZMeDPwknOWtg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-06-07 16:54           ` Rob Herring
     [not found]             ` <4DEE57D7.1030704-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-06-07 18:49               ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTik86CVS0cWOnapnh7dn5F1EOCsmVw@mail.gmail.com \
    --to=olof-nzht3qvonbneowh0uzbu5w@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).