From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olof Johansson Subject: Re: [PATCH 3/3] ARM: l2x0: Add OF based initialization Date: Wed, 1 Jun 2011 11:40:56 -0700 Message-ID: References: <1306946270-18379-1-git-send-email-robherring2@gmail.com> <1306946270-18379-4-git-send-email-robherring2@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1306946270-18379-4-git-send-email-robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Rob Herring Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Wed, Jun 1, 2011 at 9:37 AM, Rob Herring wrote: > From: Rob Herring > > This adds probing for pl310 cache controller via device tree. An example > binding looks like this: > > L2: l2-cache { > =A0 =A0 =A0 =A0compatible =3D "arm,pl310-cache", "cache"; "cache" is too generic to be useful. "arm,pl2x0-cache" would be a more meaningful fallback, I think? (Same comment as for 1/3: The bindings need to be documented. Same applies to 2/3, obviousy). -Olof