From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH 1/2] ARM: Tegra: dt: Split out separate Tegra SoC DT Date: Mon, 2 May 2011 14:15:54 -0600 Message-ID: References: <1304136751-11629-1-git-send-email-swarren@nvidia.com> <20110501145546.GC19918@quad.lixom.net> <74CDBE0F657A3D45AFBB94109FB122FF0497F1B198@HQMAIL01.nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF0497F1B198-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stephen Warren Cc: Olof Johansson , "bones-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org" , "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org On Mon, May 2, 2011 at 12:00 PM, Stephen Warren wr= ote: > Olof Johansson wrote at Sunday, May 01, 2011 8:56 AM: >> On Fri, Apr 29, 2011 at 10:12:30PM -0600, Stephen Warren wrote: >> > tegra250.dts describes everything within the Tegra SoC, but leaves= all >> > optional devices disabled. >> > >> > tegra-harmony.dts is now the configuration of the SoC for the boar= d, >> > i.e. it enables the optional devices that are required for the boa= rd, >> > and provides any required platform data for those devics. >> > >> > The prevents every Tegra board having to repeat all the basic inte= rnal >> > SoC wiring. >> > >> > Signed-off-by: Stephen Warren >> >> Acked-by: Olof Johansson >> >> A mostly unrelated question below. >> >> [...] >> >> > + =A0 serial@70006000 { >> > + =A0 =A0 =A0 =A0 =A0 compatible =3D "nvidia,tegra250-uart"; >> >> I know this is how Grant specified it, but shouldn't these also have >> a compat for ns16550? > > At present, I'm not sure it is technically compatible. If you look at > drivers/tty/serial/of_serial.c, you'll see: > > static struct of_device_id __devinitdata of_platform_serial_table[] =3D= { > ... > =A0 =A0 =A0 =A0{ .compatible =3D "ns16550", =A0.data =3D (void *)PORT= _16550, }, > ... > =A0 =A0 =A0 =A0{ .compatible =3D "nvidia,tegra250-uart", =A0.data =3D= (void *)PORT_XSCALE, }, > > That PORT_XSCALE is different to the ns16550 entry. Arguably, that > field should be something that comes from the device tree, just > like e.g. reg-shift, but it certainly doesn't right now. > > Grant, what are your thoughts on this? Heh, when I added that line I just mirrored the 'type' of 16550 as detected by the 8250.c driver when it probes and made a mental note that it should be revisited. I don't know the hardware very well, so I cannot easily say what the right thing to do is, but making it ns16550 compatible does seem to make sense. g.