From: John Williams <john.williams-g5w7nrANp4BDPfheJLI6IQ@public.gmane.org>
To: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
hjk-vqZO0P4V72/QD6PfKP4TzA@public.gmane.org
Subject: Re: [PATCH v3] uio/pdrv_genirq: Add OF support
Date: Fri, 22 Apr 2011 09:46:53 +1000 [thread overview]
Message-ID: <BANLkTinBZxBcc3fRo_jc4=VuY3D2pbaAzg@mail.gmail.com> (raw)
In-Reply-To: <20110421120855.GC2135-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Hi Wolfram,
On Thu, Apr 21, 2011 at 10:08 PM, Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> wrote:
> On Tue, Apr 19, 2011 at 11:58:25AM +1000, John Williams wrote:
>
>> As we discussed at ELC, putting a real vendor/device in there is also
>> broken because all instances in the system wil bind to the generic
>> uio, which is not necessarily what is desired.
>
> IIRC I pointed you to mpc5200b-psc devices which also have multiple functions
> and have seperate bindings for these functions. It fits the "hardware
> description" character of a dt, because it says this PSC is a UART or an
> SPI or whatever.
Right, and my interpretation of that was basically - modify the device
tree as required to make the correct driver bind to the device.
Is that correct?
It's the same underlying piece of silicon, you are just using the
device tree to tell Linux how it should behave at runtime, and which
driver to bind.
If so, it seems to be exactly what Arnd and Grant don't want - having
the device tree describe Linux behaviour.
In the hardware, it's a multifunction device, so surely a clean DTS
would just have 'mpc5200b', but no attempt to describe how Linux
should bind to it and configure it. Instead this should be done at
runtime, using some yet-to-be-determined mechanism.
The difference between what you are doing for these multifunction
devices, versus the generic-uio approach, is surely only a matter of
degree rather than fundamentals?
Regards,
John
next prev parent reply other threads:[~2011-04-21 23:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-18 8:50 [PATCH v3] uio/pdrv_genirq: Add OF support Michal Simek
2011-04-18 10:35 ` Paul Mundt
[not found] ` <20110418103513.GA27864-M7jkjyW5wf5g9hUCZPvPmw@public.gmane.org>
2011-04-18 11:10 ` Michal Simek
[not found] ` <1303116654-5042-1-git-send-email-monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org>
2011-04-18 16:06 ` Wolfram Sang
[not found] ` <20110418160658.GD23814-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-04-19 1:58 ` John Williams
2011-04-19 6:11 ` Grant Likely
2011-04-19 7:32 ` Arnd Bergmann
[not found] ` <201104190932.31777.arnd-r2nGTMty4D4@public.gmane.org>
2011-04-19 8:42 ` Michal Simek
2011-04-19 12:37 ` John Williams
2011-04-19 13:02 ` Arnd Bergmann
2011-04-19 14:49 ` Grant Likely
2011-04-19 15:07 ` Arnd Bergmann
[not found] ` <201104191707.40456.arnd-r2nGTMty4D4@public.gmane.org>
2011-04-19 15:45 ` Grant Likely
[not found] ` <BANLkTimFnfgiQ5aMq_KwqHP8p92pjOJJwg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-04-21 12:08 ` Wolfram Sang
[not found] ` <20110421120855.GC2135-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-04-21 23:46 ` John Williams [this message]
2011-04-22 6:07 ` Wolfram Sang
2011-04-19 8:16 ` Michal Simek
2011-04-19 6:08 ` Grant Likely
2011-04-19 8:15 ` Michal Simek
2011-04-19 22:00 ` Hans J. Koch
2011-04-19 23:09 ` Scott Wood
2011-04-27 11:05 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTinBZxBcc3fRo_jc4=VuY3D2pbaAzg@mail.gmail.com' \
--to=john.williams-g5w7nranp4bdpfhejli6iq@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=hjk-vqZO0P4V72/QD6PfKP4TzA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).