From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8924AC4332F for ; Tue, 11 Oct 2022 18:32:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229594AbiJKScl (ORCPT ); Tue, 11 Oct 2022 14:32:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229459AbiJKSck (ORCPT ); Tue, 11 Oct 2022 14:32:40 -0400 Received: from bg4.exmail.qq.com (bg4.exmail.qq.com [43.155.67.158]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57BE9543CB; Tue, 11 Oct 2022 11:32:38 -0700 (PDT) X-QQ-mid: bizesmtp62t1665513144tf8jdyjh Received: from [192.168.1.231] ( [113.72.146.141]) by bizesmtp.qq.com (ESMTP) with id ; Wed, 12 Oct 2022 02:32:23 +0800 (CST) X-QQ-SSF: 0100000000200090B000B00A0000000 X-QQ-FEAT: 7jw2iSiCazqbQ5tBRQTa4DP92tBGuiXW2qhhi7so1L8YQTSdLsD6bEm6SpfGf AnLtfynvp3KCljyxHGLpZg2svKBE3NjLJqiOsJHbZqld0xi6C2tJUr+vygbGy7/40QEmzCJ b3f2i3KLv3z8jeB9gNzUGEUETkotyseEm/DVu5pRoWsUhq8aaVNMc0szqOJEHy3h3fnaeiu Gqqlcg3e52/CIKA3DquCxhklE6WNgDPEmbUue3dxy/d+2kCYK7OnxiLfSATsD7w3EQPslOc 96vgfeGembZqkA73X+Wqniwr1+sDqMuKSdXKnW2uns/wYmP/O7tsErQt50YdkmtPfV1IVGE qs9V4wuExJV4i6tgmUMBOT/AtDG7mdEkioM7aScva/zOmRh7J11AhCpLh2GcQ== X-QQ-GoodBg: 0 Message-ID: Date: Wed, 12 Oct 2022 02:32:22 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH v1 30/30] RISC-V: Add StarFive JH7100 and JH7110 SoC Kconfig options Content-Language: en-US To: Conor Dooley Cc: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Daniel Lezcano , Thomas Gleixner , Marc Zyngier , Philipp Zabel , Stephen Boyd , Michael Turquette , Linus Walleij , Emil Renner Berthing , linux-kernel@vger.kernel.org References: <20220929143225.17907-1-hal.feng@linux.starfivetech.com> <20220930122318.9244-1-hal.feng@linux.starfivetech.com> From: Hal Feng In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:linux.starfivetech.com:qybglogicsvr:qybglogicsvr2 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, 30 Sep 2022 13:37:28 +0100, Conor Dooley wrote: > On Fri, Sep 30, 2022 at 08:23:18PM +0800, Hal Feng wrote: > > Add Kconfig options to select the specified StarFive SoC. Select > > necessary Kconfig options required by the specified SoC for booting. > > > > Signed-off-by: Hal Feng > > --- > > arch/riscv/Kconfig.socs | 27 ++++++++++++++++++++++++++- > > arch/riscv/boot/dts/starfive/Makefile | 4 ++-- > > drivers/clk/starfive/Kconfig | 14 ++++++-------- > > drivers/pinctrl/starfive/Kconfig | 6 ++---- > > drivers/reset/Kconfig | 1 - > > Firstly, you cannot change all of these files in one commit, sorry. > > > 5 files changed, 36 insertions(+), 16 deletions(-) > > > > diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs > > index 10f68a4359f9..321c448e7b6f 100644 > > --- a/arch/riscv/Kconfig.socs > > +++ b/arch/riscv/Kconfig.socs > > @@ -22,10 +22,35 @@ config SOC_STARFIVE > > bool "StarFive SoCs" > > select PINCTRL > > select RESET_CONTROLLER > > + select RESET_STARFIVE > > Secondly, we are trying to get rid of selects in arch/riscv at the > moment, not add them. use "default SOC_STARFIVE" in > drivers/reset/kconfig instead please. > > > + help > > + This enables support for StarFive SoC platform hardware. > > + > > +if SOC_STARFIVE > > I don't think we want to have per soc selection menus in arch code, > I think this should move to drivers/soc (a la Renesas) if you want to > have a per soc selection menu or else just do "default SOC_STARFIVE" > for both clock and pinctrl drivers in the clk and pinctrl Kconfig > entries. Thanks for your helpful comments. I will drop this patch. Best regards, Hal