Re: [PATCH v2 2/4] ASoC: dt-bindings: Add schema for FS2104/5S audio amplifiers

[Nick Li <nick.li@foursemi.com>]

On Wed, Jul 09, 2025 at 12:40:33PM +0200, Krzysztof Kozlowski wrote:
> On Tue, Jul 08, 2025 at 07:28:59PM +0800, Nick Li wrote:
> > +description:
> > +  The FS2104 is a 15W Inductor-Less, Stereo, Closed-Loop,
> > +  Digital Input Class-D Power Amplifier with Enhanced Signal Processing.
> > +  The FS2105S is a 30W Inductor-Less, Stereo, Closed-Loop,
> > +  Digital Input Class-D Power Amplifier with Enhanced Signal Processing.
> > +
> > +properties:
> > +  compatible:
> > +    oneOf:
> > +      - items:
> > +          - enum:
> > +              - foursemi,fs2104
> > +          - const: foursemi,fs2105s
> > +      - enum:
> > +          - foursemi,fs2105s
> > +
> > +  reg:
> > +    maxItems: 1
> > +    description:
> > +      I2C address of the device. Refer to datasheet for possible values
> 
> Now the description is entirely redundant, brings no value. Drop.

OK.

> 
> > +
> > +  clocks:
> > +    description: The clock of I2S BCLK
> 
> This was different... Previous code was correct, this is not correct.
> And nothing in changelog explains this. Do not make random changes after
> review.
> 

OK, I will recover it to version v1.

> > +
> > +  clock-names:
> > +    items:
> > +      - const: bclk
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  '#sound-dai-cells':
> > +    const: 0
> > +
> > +  pvdd-supply:
> > +    description:
> > +      Regulator for power supply(PVDD in datasheet).
> > +
> > +  dvdd-supply:
> > +    description:
> > +      Regulator for digital supply(DVDD in datasheet).
> > +
> > +  reset-gpios:
> > +    maxItems: 1
> > +    description:
> > +      It's the SDZ pin in datasheet, the pin is active low,
> > +      it will power down and reset the chip to shut down state.
> > +
> > +  firmware-name:
> > +    maxItems: 1
> > +    description: |
> > +      The firmware(*.bin) contains:
> > +      a. Register initialization settings
> > +      b. DSP effect parameters
> > +      c. Multi-scene sound effect configurations(optional)
> > +      It's gernerated by FourSemi's tuning tool.
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - reset-gpios
> > +  - firmware-name
> > +  - '#sound-dai-cells'
> 
> Keep the same order as in list of properties. OTOH, missing supplies.

OK, we will fix the order, but the supplies may not be used as regulator,
we mark them as required, is it OK?

Best regards,
Nick

> 
> > +
> > +allOf:
> > +  - $ref: dai-common.yaml#
> > +
> > +unevaluatedProperties: false
> 
> Best regards,
> Krzysztof
> 
>