Re: [PATCH v5 01/12] dt-bindings: PCI: Cleanup of brcmstb YAML and add 7712 SoC

[Jim Quinlan <james.quinlan@broadcom.com>]

[-- Attachment #1: Type: text/plain, Size: 1672 bytes --]

On Fri, Aug 2, 2024 at 2:43 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 01/08/2024 00:28, Jim Quinlan wrote:
> > o Change order of the compatible strings to be alphabetical
> > o Use "maxItems" where needed.
>
> I asked at v3 and then in v4 about splitting this. You never responded
> to that comment, so sorry I won't be repeating the same thing in v5.

I'm sorry Krzyszof, but I just reviewed your responses in V3 and V4
and I can't find you saying anything about splitting off the above two
bullet points.  Perhaps I am somehow losing email responses but all I
see is this in V3 is the following, where you ask me to do a squash,
not a commit:

    [JQ] o Change order of the compatible strings to be alphabetical
    []KK] That's a cleanup. You can squash it with a previous patch.

Now you did say in V3

    [JQ] o Describe resets/reset-names before using them in rules
    [KK] That's a new commit.

but this bullet item does not relate to the bullet points you have
highlighted in this email.    As for your responses to V4, I don't see
anything about splitting anything.  Again, perhaps I have somehow
missed an email.

Rather than do more round trips of email, can you confirm that this is
what you want:

A new "dt bindings" commit that only includes the changes of
    o Change order of the compatible strings to be alphabetical
    o Use "maxItems" where needed.

If the above is not what you want, please tell me unequivocally what
you would like changed, even if you think you are repeating yourself.

Regards and thanks,
Jim Quinlan
Broadcom STB/CM



>
> NAK.
>
> Best regards,
> Krzysztof
>

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4210 bytes --]