From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [PATCH 1/2] of/irq: Get rid of NO_IRQ usage Date: Tue, 6 Dec 2011 13:25:07 -0800 Message-ID: References: <20111110151852.GA7465@oksana.dev.rtsoft.ru> <20111110152541.GA3207@oksana.dev.rtsoft.ru> <4EDE877A.4080708@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: <4EDE877A.4080708@gmail.com> Sender: linux-ide-owner@vger.kernel.org To: Rob Herring Cc: Anton Vorontsov , Ingo Molnar , Jeff Garzik , Grant Likely , Stephen Rothwell , devicetree-discuss@lists.ozlabs.org, LKML , linux-ide@vger.kernel.org, Randy Dunlap , linux-next@vger.kernel.org, Andrew Morton , Alan Cox List-Id: devicetree@vger.kernel.org On Tue, Dec 6, 2011 at 1:22 PM, Rob Herring wrote: > > This warning code is really ugly. Can we just drop it? In my searching > of in kernel dts files, there's only 1 instance I have found (Versatile > AB watchdog) that would hit this. I do agree. Especially since we never got any input on whether it works or not. > If not, you don't need to handle irq_create_of_mapping return as that is > already always 0 for no irq or error. Yeah, I'd like to just remove NO_IRQ from the OF paths. Afaik, it hasn't worked as NO_IRQ before anyway, so even if the rest of the drivers end up continuing using NO_IRQ, the OF-enabled ones on ARM should just stop. There can't be many of those yet. Linus