From: Robert Marko <robert.marko@sartura.hr>
To: Rob Herring <robh@kernel.org>
Cc: agross@kernel.org, Bjorn Andersson <bjorn.andersson@linaro.org>,
kishon@ti.com, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, John Crispin <john@phrozen.org>,
Luka Perkov <luka.perkov@sartura.hr>
Subject: Re: [PATCH v4 2/3] dt-bindings: phy-qcom-ipq4019-usb: add binding document
Date: Mon, 30 Mar 2020 18:46:40 +0200 [thread overview]
Message-ID: <CA+HBbNEBCK_TfMRuKC71-dw1Wcir+43LK4ahAi9F_3kMosWJsQ@mail.gmail.com> (raw)
In-Reply-To: <20200330154056.GA22114@bogus>
On Mon, Mar 30, 2020 at 5:40 PM Rob Herring <robh@kernel.org> wrote:
>
> On Sat, 28 Mar 2020 14:53:49 +0100, Robert Marko wrote:
> > This patch adds the binding documentation for the HS/SS USB PHY found
> > inside Qualcom Dakota SoCs.
> >
> > Signed-off-by: John Crispin <john@phrozen.org>
> > Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> > Cc: Luka Perkov <luka.perkov@sartura.hr>
> > ---
> > .../bindings/phy/qcom-usb-ipq4019-phy.yaml | 45 +++++++++++++++++++
> > 1 file changed, 45 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.yaml
> >
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.yaml: while scanning a block scalar
> in "<unicode string>", line 37, column 5
> found a tab character where an indentation space is expected
> in "<unicode string>", line 39, column 1
> Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.example.dts' failed
> make[1]: *** [Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.example.dts] Error 1
> make[1]: *** Waiting for unfinished jobs....
> warning: no schema found in file: Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.yaml
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.yaml: ignoring, error parsing file
> Makefile:1262: recipe for target 'dt_binding_check' failed
> make: *** [dt_binding_check] Error 2
>
> See https://patchwork.ozlabs.org/patch/1263219
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure dt-schema is up to date:
>
> pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
>
> Please check and re-submit.
Thanks,
I fixed it and pushed v5.
Cheers
Robert
next prev parent reply other threads:[~2020-03-30 16:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-28 13:53 [PATCH v4 1/3] phy: add driver for Qualcomm IPQ40xx USB PHY Robert Marko
2020-03-28 13:53 ` [PATCH v4 2/3] dt-bindings: phy-qcom-ipq4019-usb: add binding document Robert Marko
2020-03-30 15:40 ` Rob Herring
2020-03-30 16:46 ` Robert Marko [this message]
2020-03-28 13:53 ` [PATCH v4 3/3] ARM: dts: qcom: ipq4019: add USB devicetree nodes Robert Marko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+HBbNEBCK_TfMRuKC71-dw1Wcir+43LK4ahAi9F_3kMosWJsQ@mail.gmail.com \
--to=robert.marko@sartura.hr \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=john@phrozen.org \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luka.perkov@sartura.hr \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).