From: Robert Marko <robert.marko@sartura.hr>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, luka.perkov@sartura.hr
Subject: Re: [PATCH] ARM: dts: qcom: ipq4019: correct SDHCI XO clock
Date: Fri, 11 Aug 2023 10:46:07 +0200 [thread overview]
Message-ID: <CA+HBbNFGrF7gCKGuQuYRb6iZnzxV+=Gvde5DVi16vUnFfs1ZMA@mail.gmail.com> (raw)
In-Reply-To: <900276ca-a682-4be0-a3dd-1794a3e62224@linaro.org>
On Thu, Aug 10, 2023 at 7:56 PM Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>
> On 10.08.2023 15:28, Robert Marko wrote:
> > Using GCC_DCD_XO_CLK as the XO clock for SDHCI controller is not correct,
> > it seems that I somehow made a mistake of passing it instead of the fixed
> > XO clock.
> >
> > Fixes: 04b3b72b5b8f ("ARM: dts: qcom: ipq4019: Add SDHCI controller node")
> > Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> > ---
> Is this another IPQ without RPM?
Yes, AFAIK there is no RPM on this one.
>
> If so, this patch looks good, but please take the liberty to make clocks
> and clock-names one-per-line :)
Will do in v2.
Regards,
Robert
>
> Konrad
--
Robert Marko
Staff Embedded Linux Engineer
Sartura Ltd.
Lendavska ulica 16a
10000 Zagreb, Croatia
Email: robert.marko@sartura.hr
Web: www.sartura.hr
next prev parent reply other threads:[~2023-08-11 8:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 13:28 [PATCH] ARM: dts: qcom: ipq4019: correct SDHCI XO clock Robert Marko
2023-08-10 17:56 ` Konrad Dybcio
2023-08-11 8:46 ` Robert Marko [this message]
2023-08-11 15:20 ` Bjorn Andersson
2023-08-11 15:22 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+HBbNFGrF7gCKGuQuYRb6iZnzxV+=Gvde5DVi16vUnFfs1ZMA@mail.gmail.com' \
--to=robert.marko@sartura.hr \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luka.perkov@sartura.hr \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).