Re: [PATCH v2 02/11] dt-bindings: marvell: convert Armada 37xx compatibles to YAML

[Robert Marko <robert.marko@sartura.hr>]

On Wed, May 11, 2022 at 6:52 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 10/05/2022 14:49, Robert Marko wrote:
>
> Thank you for your patch. There is something to discuss/improve.
>
> > -
> > - - compatible: must contain "cznic,turris-mox"
> > diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-37xx.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-37xx.yaml
> > new file mode 100644
> > index 000000000000..3f41ef2c6f3e
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/arm/marvell/armada-37xx.yaml
> > @@ -0,0 +1,50 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/arm/marvell/armada-37xx.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Marvell Armada 37xx Platforms Device Tree Bindings
> > +
> > +maintainers:
> > +  - Robert Marko <robert.marko@sartura.hr>
> > +
> > +properties:
> > +  $nodename:
> > +    const: '/'
> > +  compatible:
> > +    oneOf:
> > +      - description: Armada 3710 SoC
> > +        items:
> > +          - const: marvell,armada3710
>
> This does not look correct. The SoC usually cannot be used by itself,
> it's always a part of some product, SoM, board.

Hi Krzysztof,
Currently, there are no Armada 3710 boards present in Linux, so I just
put the SoC compatible.
If that is not appropriate, I can drop it.

>
> > +
> > +      - description: Armada 3720 SoC
> > +        items:
> > +          - enum:
> > +              - marvell,armada-3720-db
> > +              - globalscale,espressobin
> > +              - cznic,turris-mox
> > +              - methode,udpu
>
> Order by name.
Will fixup in v3.

>
> > +          - const: marvell,armada3720
> > +          - const: marvell,armada3710
> > +
> > +      - description: Globalscale Espressobin boards
> > +        items:
> > +          - enum:
> > +              - globalscale,espressobin-emmc
> > +              - globalscale,espressobin-ultra
> > +              - globalscale,espressobin-v7
> > +          - const: globalscale,espressobin
> > +          - const: marvell,armada3720
> > +          - const: marvell,armada3710
Do these const compatibles also need to be in alphabetical ordering,
cause I ported them as they are meant to be used with the board and
then 3720 compatibles being in front of 3710 one as required by the current
text bindings.

Regards,
Robert
> > +
> > +      - description: Globalscale Espressobin V7 boards
> > +        items:
> > +          - enum:
> > +              - globalscale,espressobin-v7-emmc
> > +          - const: globalscale,espressobin-v7
> > +          - const: globalscale,espressobin
> > +          - const: marvell,armada3720
> > +          - const: marvell,armada3710
> > +
> > +additionalProperties: true
>
>
> Best regards,
> Krzysztof



-- 
Robert Marko
Staff Embedded Linux Engineer
Sartura Ltd.
Lendavska ulica 16a
10000 Zagreb, Croatia
Email: robert.marko@sartura.hr
Web: www.sartura.hr