From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4071AC433F5 for ; Thu, 12 May 2022 12:26:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232646AbiELM0i (ORCPT ); Thu, 12 May 2022 08:26:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353970AbiELM03 (ORCPT ); Thu, 12 May 2022 08:26:29 -0400 Received: from mail-il1-x12e.google.com (mail-il1-x12e.google.com [IPv6:2607:f8b0:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1529453B5D for ; Thu, 12 May 2022 05:26:24 -0700 (PDT) Received: by mail-il1-x12e.google.com with SMTP id i22so3414247ila.1 for ; Thu, 12 May 2022 05:26:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sartura-hr.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MwYIAF3cq8G3u9Ili7Yhf5dC/zi9S7Kv9orW3ndyyMo=; b=xTNWxvaZpM3RIRF+c17vz2buBi9TO3q0Z8ZgBNj48ZR9clc2FfK/UCy0G7zvhxlaeJ Aj1uMDAg0bhohTIXxFfKVwSJCKPvgmLY0xLLOdPoX9WY+8GPpLLIVGMT/Nxqi8luuVg5 6g9enenQBEath3GvnAy2JD9vjbNdf+q/Sd8OpuoJe/Toalwtap2L+g8jUxiIlQvx2lP4 EokHmG0APOOnQZw4EWwASwkkBst1Y0DQ/JVK0JNzO0L4LgvhoH/cXUNcHAM6HtBmF8vG XO2ZVL6BDkZNpGdXKY6o5mBaz/nf9qU+hdKma0/bc8wPMZXLQF9XsNbGsAxZaj7lTRo0 Gscg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MwYIAF3cq8G3u9Ili7Yhf5dC/zi9S7Kv9orW3ndyyMo=; b=IYfUUV58aTLZqN5UkytMXzt4UCI/HRa9Le4WGRpLfp8QnQoOXOwbBvVwC3jy6DnySa 33DE4lhDGPVNsL7lANSDPqUpRbMmPwkCKzGaFNzilLQUA8QHQJzktgWg1ft6Dr3lQrp2 EBB3mDO+sXK//tKu9OAE5I2xkn3nfmlROeuYF7qUa6zZ4zRVJZJqqYOn8Gh5Zpr5WFx+ yO3eEw42s3lCgkPWXIbCod/EdJy1OzxaJvJyYgMSpIeSjhGgrwfLGH5f2lr/1QSLkKKR 0Ujs3/kKY79cM12VWteidQlEm2AuHFm0vOku3K7YuLcY6BaMV7QPkrV3Tg4KiKNGUuTD v1KQ== X-Gm-Message-State: AOAM530PG2ItPSc4IGrdGALDu415AwYzTLwMlwqVCzJhGULjFtbxBj24 96u/JALPewZ676GHRmdjEQJHdt+OjrJJjJNIOE4rYw== X-Google-Smtp-Source: ABdhPJw1Mn/rYopWnBcxdUmVQgBRtHp0rWD0yynzcXfeeIA6XHLAfB7cjfGXcYrldDJTX7JH/wSLwSWlfM+XAHtdMug= X-Received: by 2002:a05:6e02:154b:b0:2cf:7701:47e3 with SMTP id j11-20020a056e02154b00b002cf770147e3mr14459824ilu.40.1652358383440; Thu, 12 May 2022 05:26:23 -0700 (PDT) MIME-Version: 1.0 References: <20220510124929.91000-1-robert.marko@sartura.hr> <20220510124929.91000-2-robert.marko@sartura.hr> <0815f581-ca5b-6fb6-a59e-f5d0a3686caa@linaro.org> In-Reply-To: <0815f581-ca5b-6fb6-a59e-f5d0a3686caa@linaro.org> From: Robert Marko Date: Thu, 12 May 2022 14:26:12 +0200 Message-ID: Subject: Re: [PATCH v2 02/11] dt-bindings: marvell: convert Armada 37xx compatibles to YAML To: Krzysztof Kozlowski Cc: Rob Herring , krzysztof.kozlowski+dt@linaro.org, Andrew Lunn , gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, kostap@marvell.com, devicetree , Linux Kernel Mailing List , Linux ARM , =?UTF-8?Q?Pali_Roh=C3=A1r?= , =?UTF-8?B?TWFyZWsgQmVow7pu?= Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, May 11, 2022 at 6:52 PM Krzysztof Kozlowski wrote: > > On 10/05/2022 14:49, Robert Marko wrote: > > Thank you for your patch. There is something to discuss/improve. > > > - > > - - compatible: must contain "cznic,turris-mox" > > diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-37xx.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-37xx.yaml > > new file mode 100644 > > index 000000000000..3f41ef2c6f3e > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/arm/marvell/armada-37xx.yaml > > @@ -0,0 +1,50 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/arm/marvell/armada-37xx.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Marvell Armada 37xx Platforms Device Tree Bindings > > + > > +maintainers: > > + - Robert Marko > > + > > +properties: > > + $nodename: > > + const: '/' > > + compatible: > > + oneOf: > > + - description: Armada 3710 SoC > > + items: > > + - const: marvell,armada3710 > > This does not look correct. The SoC usually cannot be used by itself, > it's always a part of some product, SoM, board. Hi Krzysztof, Currently, there are no Armada 3710 boards present in Linux, so I just put the SoC compatible. If that is not appropriate, I can drop it. > > > + > > + - description: Armada 3720 SoC > > + items: > > + - enum: > > + - marvell,armada-3720-db > > + - globalscale,espressobin > > + - cznic,turris-mox > > + - methode,udpu > > Order by name. Will fixup in v3. > > > + - const: marvell,armada3720 > > + - const: marvell,armada3710 > > + > > + - description: Globalscale Espressobin boards > > + items: > > + - enum: > > + - globalscale,espressobin-emmc > > + - globalscale,espressobin-ultra > > + - globalscale,espressobin-v7 > > + - const: globalscale,espressobin > > + - const: marvell,armada3720 > > + - const: marvell,armada3710 Do these const compatibles also need to be in alphabetical ordering, cause I ported them as they are meant to be used with the board and then 3720 compatibles being in front of 3710 one as required by the current text bindings. Regards, Robert > > + > > + - description: Globalscale Espressobin V7 boards > > + items: > > + - enum: > > + - globalscale,espressobin-v7-emmc > > + - const: globalscale,espressobin-v7 > > + - const: globalscale,espressobin > > + - const: marvell,armada3720 > > + - const: marvell,armada3710 > > + > > +additionalProperties: true > > > Best regards, > Krzysztof -- Robert Marko Staff Embedded Linux Engineer Sartura Ltd. Lendavska ulica 16a 10000 Zagreb, Croatia Email: robert.marko@sartura.hr Web: www.sartura.hr