From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EA51ECAAD1 for ; Wed, 31 Aug 2022 11:12:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229752AbiHaLMU (ORCPT ); Wed, 31 Aug 2022 07:12:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229510AbiHaLMT (ORCPT ); Wed, 31 Aug 2022 07:12:19 -0400 Received: from mail-oa1-x2d.google.com (mail-oa1-x2d.google.com [IPv6:2001:4860:4864:20::2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A687CEB2A for ; Wed, 31 Aug 2022 04:12:18 -0700 (PDT) Received: by mail-oa1-x2d.google.com with SMTP id 586e51a60fabf-11f11d932a8so14883945fac.3 for ; Wed, 31 Aug 2022 04:12:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sartura.hr; s=sartura; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=sJH+8p5AtjeeuMnWmoPAbxDcXoEr/hihkiuokZEt+xs=; b=KiHcHM7+/5UKpbapOwznFZR+Awj8ouNl6UC4vXytttIEdsVgifeBzD2mFOC0nysXjy j+LfgrC0EMFd1d+rpQJlfSQv+v+iy8RUPqvtBJkMzH4K6zpq845PiL5bm+fsundOZtlg 7CH3Aq/njUBZHYZDr2Y9vlA6bX12QAX/wTU/NSGTCikvSk6j0+5Le//qA6sSuYZghXsU yOqKhMJaSwLlMXZ9emDmLZE3yUB2VfZbLCRZdaEhngusL7vIIWe7Ougj247KuHxdnv04 +9ZrYV0aWbsuuifnhkg5PtIm35Sa7qp1UqLPEl2qVNKSlZ47KPgtFzp7Ghq+xj/8HVVx MgcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=sJH+8p5AtjeeuMnWmoPAbxDcXoEr/hihkiuokZEt+xs=; b=1kfa1ukrX4kdrWrIqMZVyCLy32GviYrwJohAR10UcpTH+XKgS9ku8XmfSsuKea5mKp DId6DFu0FuRWbgRXM6JaRSSCAqoz3QY88k9Z30ZImuuZtt4gJwAkSRdapC90ifROiz65 51TMWfTzxVwKNQbKnkfiSw7issy6BlFE/bEbLN3/Na5CZxV5fPZiZVnonQEshS6lGE4g w2Jl5Y/WvqCVR8kEZ55+S1PHQOycn4uDaeFi0BalaqtgkDH1D/rDfxxtmyts5k0KCo7F Cr6Pvh3O9PEN3dqvcu8GxheOnOp8SecGeu6FX9ayA6P1UVLcJV2cFr2CsnbDp21ETTJo 433w== X-Gm-Message-State: ACgBeo2YjsRbD/9u+zi5ckLJ7ffiotFAbSZnjjd4XZYmztr6LxO4Ne+5 lUCpDsDydU0j20RqCvBxcfLPHZ4JwS4tisr4LGC6SA== X-Google-Smtp-Source: AA6agR6Otmzk4Kk/s43tJZQHK9B9/4L56sa/82Eewo7SR4MuZgVfgMuFa/XtqxbidkOI8YYMGIiazDGLGbxY19x9ouk= X-Received: by 2002:a05:6870:783:b0:11c:7d1c:6ede with SMTP id en3-20020a056870078300b0011c7d1c6edemr1091545oab.239.1661944337671; Wed, 31 Aug 2022 04:12:17 -0700 (PDT) MIME-Version: 1.0 References: <20220516124828.45144-1-robert.marko@sartura.hr> <20220516124828.45144-10-robert.marko@sartura.hr> <87mtbm5gaf.fsf@BL-laptop> In-Reply-To: <87mtbm5gaf.fsf@BL-laptop> From: Robert Marko Date: Wed, 31 Aug 2022 13:12:06 +0200 Message-ID: Subject: Re: [PATCH v4 10/10] arm64: dts: marvell: add support for Methode eDPU To: Gregory CLEMENT Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, andrew@lunn.ch, sebastian.hesselbarth@gmail.com, kostap@marvell.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Aug 30, 2022 at 9:42 AM Gregory CLEMENT wrote: > > Robert Marko writes: > > > On Mon, May 16, 2022 at 2:48 PM Robert Marko wrote: > >> > >> Methode eDPU is an Armada 3720 powered board based on the Methode uDPU. > >> > >> They feature the same CPU, RAM, and storage as well as the form factor. > >> > >> However, eDPU only has one SFP slot plus a copper G.hn port. > >> > >> Signed-off-by: Robert Marko > >> Reviewed-by: Krzysztof Kozlowski > >> --- > >> Changes in v2: > >> * Make the DTS split a separate commit > >> --- > >> arch/arm64/boot/dts/marvell/Makefile | 1 + > >> arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts | 14 ++++++++++++++ > >> 2 files changed, 15 insertions(+) > >> create mode 100644 arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts > >> > >> diff --git a/arch/arm64/boot/dts/marvell/Makefile b/arch/arm64/boot/dts/marvell/Makefile > >> index 1c794cdcb8e6..104d7d7e8215 100644 > >> --- a/arch/arm64/boot/dts/marvell/Makefile > >> +++ b/arch/arm64/boot/dts/marvell/Makefile > >> @@ -1,6 +1,7 @@ > >> # SPDX-License-Identifier: GPL-2.0 > >> # Mvebu SoC Family > >> dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-db.dtb > >> +dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-eDPU.dtb > >> dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin.dtb > >> dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin-emmc.dtb > >> dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin-ultra.dtb > >> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts b/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts > >> new file mode 100644 > >> index 000000000000..57fc698e55d0 > >> --- /dev/null > >> +++ b/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts > >> @@ -0,0 +1,14 @@ > >> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > >> + > >> +/dts-v1/; > >> + > >> +#include "armada-3720-uDPU.dtsi" > >> + > >> +/ { > >> + model = "Methode eDPU Board"; > >> + compatible = "methode,edpu", "marvell,armada3720", "marvell,armada3710"; > >> +}; > >> + > >> +ð0 { > >> + phy-mode = "2500base-x"; > >> +}; > >> -- > >> 2.36.1 > >> > > > > Hi Gregory, > Hello Roberto, > > > Is there something else that I can improve in the series? > > Sorry for having missed this series. At first view it seems OK, I am > going to have a closer look this week. Thanks, that sounds good. Regards, Robert > > Gregory > > > > > > Regards, > > Robert > > > > -- > > Robert Marko > > Staff Embedded Linux Engineer > > Sartura Ltd. > > Lendavska ulica 16a > > 10000 Zagreb, Croatia > > Email: robert.marko@sartura.hr > > Web: www.sartura.hr > > -- > Gregory Clement, Bootlin > Embedded Linux and Kernel engineering > http://bootlin.com -- Robert Marko Staff Embedded Linux Engineer Sartura Ltd. Lendavska ulica 16a 10000 Zagreb, Croatia Email: robert.marko@sartura.hr Web: www.sartura.hr