Re: [PATCH 11/13] arm64: dts: renesas: rzt2h/rzn2h: Enable eMMC

["Lad, Prabhakar" <prabhakar.csengg@gmail.com>]

Hi Geert,

Thank you for the review.

On Mon, Aug 18, 2025 at 5:02 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Prabhakar,
>
> On Tue, 12 Aug 2025 at 22:03, Prabhakar <prabhakar.csengg@gmail.com> wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > Enable eMMC on RZ/T2H and RZ/N2H EVKs. As SDHI0 can be connected to
> > either eMMC0/SD0 `SD0_EMMC` macro is added.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Thanks for your patch!
>
> > --- a/arch/arm64/boot/dts/renesas/r9a09g087m44-rzn2h-evk.dts
> > +++ b/arch/arm64/boot/dts/renesas/r9a09g087m44-rzn2h-evk.dts
> > @@ -10,6 +10,15 @@
> >  #include <dt-bindings/gpio/gpio.h>
> >
> >  #include "r9a09g087m44.dtsi"
> > +
> > +/*
> > + * SD0 can be connected to either eMMC (U33) or SD card slot CN21
> > + * Lets by default enable the eMMC, note we need the below SW settings
> > + * for eMMC.
> > + * DSW5[1] = ON; DSW5[2] = ON
> > + */
>
> Both SD0 and eMMC also need DSW17[5] = OFF; DSW17[6] = ON.
>
Agreed.

> > +#define SD0_EMMC       1
> > +
> >  #include "rzt2h-n2h-evk-common.dtsi"
> >
> >  /*
>
> > --- a/arch/arm64/boot/dts/renesas/rzt2h-n2h-evk-common.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/rzt2h-n2h-evk-common.dtsi
>
> > @@ -44,6 +63,34 @@ sci0_pins: sci0-pins {
> >                 pinmux = <RZT2H_PORT_PINMUX(27, 4, 0x14)>,
> >                          <RZT2H_PORT_PINMUX(27, 5, 0x14)>;
> >         };
> > +
> > +#if SD0_EMMC
> > +       sdhi0-emmc-iovs-hog {
> > +               gpio-hog;
> > +               gpios = <RZT2H_GPIO(2, 6) GPIO_ACTIVE_HIGH>;
> > +               output-high;
> > +               line-name = "SD0_IOVS";
> > +       };
> > +#endif
> > +
> > +       sdhi0_emmc_pins: sd0-emmc-group {
> > +               sd0-emmc-data-pins {
>
> No need for repeated sd0-emmc-prefixes in the subnodes.
>
>
Ok, I will get rid of them.

Cheers,
Prabhakar

> > +                       pinmux = <RZT2H_PORT_PINMUX(12, 2, 0x29)>, /* SD0_DATA0 */
> > +                                <RZT2H_PORT_PINMUX(12, 3, 0x29)>, /* SD0_DATA1 */
> > +                                <RZT2H_PORT_PINMUX(12, 4, 0x29)>, /* SD0_DATA2 */
> > +                                <RZT2H_PORT_PINMUX(12, 5, 0x29)>, /* SD0_DATA3 */
> > +                                <RZT2H_PORT_PINMUX(12, 6, 0x29)>, /* SD0_DATA4 */
> > +                                <RZT2H_PORT_PINMUX(12, 7, 0x29)>, /* SD0_DATA5 */
> > +                                <RZT2H_PORT_PINMUX(13, 0, 0x29)>, /* SD0_DATA6 */
> > +                                <RZT2H_PORT_PINMUX(13, 1, 0x29)>; /* SD0_DATA7 */
> > +               };
> > +
> > +               sd0-emmc-ctrl-pins {
> > +                       pinmux = <RZT2H_PORT_PINMUX(12, 0, 0x29)>, /* SD0_CLK */
> > +                                <RZT2H_PORT_PINMUX(12, 1, 0x29)>, /* SD0_CMD */
> > +                                <RZT2H_PORT_PINMUX(13, 2, 0x29)>; /* SD0_RST# */
> > +               };
> > +       };
> >  };
>
> The rest LGTM.
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds