From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "Clément Léger" <clement.leger@bootlin.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Magnus Damm" <magnus.damm@gmail.com>,
"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
linux-renesas-soc@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
"Biju Das" <biju.das.jz@bp.renesas.com>,
"Fabrizio Castro" <fabrizio.castro.jz@renesas.com>,
"Lad Prabhakar" <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH net-next v2 8/9] net: pcs: rzn1-miic: Add per-SoC control for MIIC register unlock/lock
Date: Fri, 5 Sep 2025 12:48:37 +0100 [thread overview]
Message-ID: <CA+V-a8sP1HBmBr_mbJTwVRAu-ZxKiT7b9KW3o97HOhu8DAUavg@mail.gmail.com> (raw)
In-Reply-To: <fc103af7-0558-46bf-a668-d4d815ae704e@lunn.ch>
Hi Andrew,
Thank you for the review.
On Thu, Sep 4, 2025 at 9:55 PM Andrew Lunn <andrew@lunn.ch> wrote:
>
> > -static void miic_reg_writel(struct miic *miic, int offset, u32 value)
> > +static inline void miic_unlock_regs(struct miic *miic)
> > +{
>
> Please don't use inline in C files. The compiler should decide.
>
Ok, I will drop this in the next version.
Cheers,
Prabhakar
next prev parent reply other threads:[~2025-09-05 11:49 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 11:41 [PATCH net-next v2 0/9] Add PCS support for Renesas RZ/{T2H,N2H} SoCs Prabhakar
2025-09-04 11:41 ` [PATCH net-next v2 1/9] dt-bindings: net: pcs: renesas,rzn1-miic: Add RZ/T2H and RZ/N2H support Prabhakar
2025-09-04 11:41 ` [PATCH net-next v2 2/9] net: pcs: rzn1-miic: Drop trailing comma from of_device_id table Prabhakar
2025-09-04 20:16 ` Andrew Lunn
2025-09-04 11:41 ` [PATCH net-next v2 3/9] net: pcs: rzn1-miic: Add missing include files Prabhakar
2025-09-04 20:16 ` Andrew Lunn
2025-09-04 11:41 ` [PATCH net-next v2 4/9] net: pcs: rzn1-miic: Move configuration data to SoC-specific struct Prabhakar
2025-09-04 11:41 ` [PATCH net-next v2 5/9] net: pcs: rzn1-miic: move port range handling into SoC data Prabhakar
2025-09-04 20:24 ` Andrew Lunn
2025-09-04 11:42 ` [PATCH net-next v2 6/9] net: pcs: rzn1-miic: Make switch mode mask SoC-specific Prabhakar
2025-09-04 20:37 ` Andrew Lunn
2025-09-05 7:02 ` Geert Uytterhoeven
2025-09-05 10:01 ` Lad, Prabhakar
2025-09-05 12:02 ` Lad, Prabhakar
2025-09-04 11:42 ` [PATCH net-next v2 7/9] net: pcs: rzn1-miic: Add support to handle resets Prabhakar
2025-09-04 20:43 ` Andrew Lunn
2025-09-04 11:42 ` [PATCH net-next v2 8/9] net: pcs: rzn1-miic: Add per-SoC control for MIIC register unlock/lock Prabhakar
2025-09-04 20:55 ` Andrew Lunn
2025-09-05 11:48 ` Lad, Prabhakar [this message]
2025-09-04 11:42 ` [PATCH net-next v2 9/9] net: pcs: rzn1-miic: Add RZ/T2H MIIC support Prabhakar
2025-09-04 20:57 ` Andrew Lunn
2025-09-05 11:49 ` Lad, Prabhakar
2025-09-04 12:41 ` [PATCH net-next v2 0/9] Add PCS support for Renesas RZ/{T2H,N2H} SoCs Simon Horman
2025-09-04 12:47 ` Lad, Prabhakar
2025-09-06 12:19 ` Wolfram Sang
2025-09-10 10:18 ` Wolfram Sang
2025-09-10 19:06 ` Lad, Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+V-a8sP1HBmBr_mbJTwVRAu-ZxKiT7b9KW3o97HOhu8DAUavg@mail.gmail.com \
--to=prabhakar.csengg@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=biju.das.jz@bp.renesas.com \
--cc=clement.leger@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=fabrizio.castro.jz@renesas.com \
--cc=geert+renesas@glider.be \
--cc=hkallweit1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=magnus.damm@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).