From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Lad, Prabhakar" Subject: Re: [PATCH v5 3/4] media: ov2640: add primary dt support Date: Thu, 26 Feb 2015 00:36:05 +0000 Message-ID: References: <1423560696-12304-1-git-send-email-josh.wu@atmel.com> <1423560696-12304-4-git-send-email-josh.wu@atmel.com> <54ED4772.902@atmel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <54ED4772.902@atmel.com> Sender: linux-media-owner@vger.kernel.org To: Josh Wu Cc: Guennadi Liakhovetski , Laurent Pinchart , Linux Media Mailing List , "devicetree@vger.kernel.org" , LAK List-Id: devicetree@vger.kernel.org Hi Josh, On Wed, Feb 25, 2015 at 3:54 AM, Josh Wu wrote: > Hi, Prabhakar Lad > > > On 2/17/2015 12:48 AM, Lad, Prabhakar wrote: >> >> Hi Josh, >> >> Thanks for the patch. >> >> On Tue, Feb 10, 2015 at 9:31 AM, Josh Wu wrote: >> [Snip] >>> >>> - priv->clk =3D v4l2_clk_get(&client->dev, "mclk"); >>> + priv->clk =3D v4l2_clk_get(&client->dev, "xvclk"); >> >> with this change don=E2=80=99t you need to update the board file usi= ng this >> driver/ >> the bridge driver ? > > I think no. > > First, my patch should be on top of the following two patches, which = changed > the *v4l2_clk_get()* behavior: > [v3,1/2] V4L: remove clock name from v4l2_clk API > https://patchwork.linuxtv.org/patch/28108/ > [v4,2/2] V4L: add CCF support to the v4l2_clk API > https://patchwork.linuxtv.org/patch/28111/ > Thanks I missed the dependent patches. Cheers, --Prabhakar Lad