From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6946C43603 for ; Mon, 16 Dec 2019 08:56:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A4F1A20725 for ; Mon, 16 Dec 2019 08:56:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FjlOHfjU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726818AbfLPI4D (ORCPT ); Mon, 16 Dec 2019 03:56:03 -0500 Received: from mail-ot1-f66.google.com ([209.85.210.66]:39082 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726772AbfLPI4D (ORCPT ); Mon, 16 Dec 2019 03:56:03 -0500 Received: by mail-ot1-f66.google.com with SMTP id 77so8254795oty.6; Mon, 16 Dec 2019 00:56:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kYtpzi4OVKtcejBRTQymtnHqpwZ9IMOgfskqRMoMYJk=; b=FjlOHfjUAfcuD6g8sPuagxsQz5NN8GYgQkKB5eMFUDSFQVwSP89GYTqlut3C2mn/YS eBOmWEFi3DmQuTp/qkgihQaDk97WF8xOzKLyWA49CUntFhQp+iGILFSDaYtSjG/0u4Wj LxTSyOx9E//ppj6YpXZ9za8Llr1VmVC8BQXLoBKo0CW3HilP1RhaTFw1FQjulLbUp223 mcF16tAkJWH/7f/hSfMy6k/MJDZnaM06WaiErKL/enY0E/Lb5Y7170h/2S8KarFCyZDD CgTiwf8HwXNonQvRTdFiPmrTUBGgr+ds+XVrfdLY1VYSxeJGxr4PI7XI3xP99XeFpSks XLNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kYtpzi4OVKtcejBRTQymtnHqpwZ9IMOgfskqRMoMYJk=; b=RPYjI3gwP83QcQqzhxK/prh5vQhNuhlVOh5qOzqkXImdY5cFJ6XypF5jLJ8+OSF8RC XSW6ZpvL7bjMYmSQcnR0DJZtLorc8yK+cSg4EFSr0qh/XHa3YJJnG+QmxXgs4g3xmWvA wkioxxZykys6C7vyDHfM+ClwuiY5cM8h+Pv3kP/RzLX+EN2gdiO8RG9RFqacemGqpWe2 zxYAojJ4WoiQBraxp0k0yV9IqiFSl/RAEfAmRnQgHgoZF0F9s5IigrydQ9ApnZH0hoZQ NgBt33MutVTzl0zTPf+KVxs9K3appRL7ZiQ/7Y153M+lY9BzJSzUvLMESmhuZD9iukjz oHVg== X-Gm-Message-State: APjAAAWKZa9yihn/6DhMbzE7j9O4osVchadOusA84c5rSIm2rl7ixtaw OUkL1LldHSsGa1nUtJGJcbpiaQsbp71nbcXgQo8= X-Google-Smtp-Source: APXvYqxuG1NFvuEk8dd9qCJss5ujNitykdgf+GtcWeO9MK3yKpQRtT4rBhNxc5bDbHMtxvDMRwurT0NSEqfrjfpI+2g= X-Received: by 2002:a05:6830:147:: with SMTP id j7mr15118795otp.44.1576486562033; Mon, 16 Dec 2019 00:56:02 -0800 (PST) MIME-Version: 1.0 References: <20191213084748.11210-4-prabhakar.mahadev-lad.rj@bp.renesas.com> <20191213201944.GA190383@google.com> In-Reply-To: <20191213201944.GA190383@google.com> From: "Lad, Prabhakar" Date: Mon, 16 Dec 2019 08:55:35 +0000 Message-ID: Subject: Re: [v2 3/6] of: address: add support to parse PCI outbound-ranges To: Bjorn Helgaas Cc: Rob Herring , Mark Rutland , Geert Uytterhoeven , Magnus Damm , Kishon Vijay Abraham I , Marek Vasut , Yoshihiro Shimoda , linux-pci , Catalin Marinas , Will Deacon , Lorenzo Pieralisi , Arnd Bergmann , Greg Kroah-Hartman , Andrew Murray , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , LAK , Linux-Renesas , Chris Paterson , Frank Rowand , Gustavo Pimentel , Jingoo Han , Simon Horman , Shawn Lin , Tom Joseph , Heiko Stuebner , linux-rockchip@lists.infradead.org, "Lad, Prabhakar" Content-Type: text/plain; charset="UTF-8" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Bjorn, Thank you for the review. On Fri, Dec 13, 2019 at 9:05 PM Bjorn Helgaas wrote: > > On Fri, Dec 13, 2019 at 08:47:45AM +0000, Lad Prabhakar wrote: > > From: "Lad, Prabhakar" > > $ git log --oneline drivers/of/address.c > 951d48855d86 of: Make of_dma_get_range() work on bus nodes > 645c138636de of/address: Fix of_pci_range_parser_one translation of DMA addresses > 81db12ee15cb of/address: Translate 'dma-ranges' for parent nodes missing 'dma-ranges' > b68ac8dc22eb of: Factor out #{addr,size}-cells parsing > c60bf3eb888a of: address: Follow DMA parent for "dma-coherent" > 862ab5578f75 of/address: Introduce of_get_next_dma_parent() helper > > Make yours match. There are a few "of: address: " subjects, but the > ones from Rob (the maintainer) use "of/address: ", so I'd use that. > will do the same for next iteration. > > this patch adds support to parse PCI outbound-ranges, the > > outbound-regions are similar to pci ranges except it doesn't > > have pci address, below is the format for bar-ranges: > > s/pci/PCI/ > Capitalize sentences. > will fix that. > Is "bar-range" an actual DT property? If it's supposed to be a > generic description, "BAR range" would be better. > my bad, it should be outbound-range. Cheers, --Prabhakar > > outbound-ranges = > upper32_size lower32_size>;