From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com [209.85.219.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C42CF1A4F2D; Thu, 20 Jun 2024 10:00:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718877603; cv=none; b=aYuQXv0fFDuvzREfccQTRt8LhRt4JqRHnGLPH9bLK9wvEAH52E6XED/QQoOUfda0opk1vfLXjnZQOIB3N6M/7mnUSfAkYN+h1MCrswJjpk/LmSKw0dPZYRvJ1Kds8sG+YxwPZ5wNNPzBkz0+H0LgXXUkiWhbsMfCglIZRm1N77A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718877603; c=relaxed/simple; bh=/iZzAiTQ5UNxV0/HtKdwOhMREms4rHsGBjYD5hM252w=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=FjuZQkG8VgZZbjXXajW1279BtazYbBhntRbcRoEvnTML8F1ChUeXi6N6XeoaySWsgm4m3A2XK7YKsVNGjsLOuov45+r3q9kNYGWykVMHREktOpeKnda+jtbb9nspBRXTDlIkS7LCF3A1Ckyi6EiOa/Oj+WqG8akwWA4u6hegW3U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=h52Acn9m; arc=none smtp.client-ip=209.85.219.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h52Acn9m" Received: by mail-yb1-f171.google.com with SMTP id 3f1490d57ef6-e02bda4aba3so702959276.3; Thu, 20 Jun 2024 03:00:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718877601; x=1719482401; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/iZzAiTQ5UNxV0/HtKdwOhMREms4rHsGBjYD5hM252w=; b=h52Acn9mwzjaU7kooJFt10M1SNBBKkndEx68W13FJ+6Sj6nx3ZeXtUyknIzN0cVYdA 7xvRK3cQE6uDe2mvYeNx3wYtiOdlrC7tnOnAZ4m3oFu+2ekVtmXAZW5VRj4HMel+7IB6 M7M5kmFzCRWZS4f/QLpBK1Cd3wJjkLJrSBygAQb+U+vjCmFTYC4JwaksOJ4nz/lI/AnO 40ntvL6R50PkuqpBENNKn1YU564KEtPy6Fdjqx/6UJhUuPI/ZdPZiC1u4hBpmlXSZlMF bYw0kpA42FgubIj0dNeT+Z2iZOa/IkIZo2RdV4mmiRYtTAmyYuyMaoui4lJQ3FXNk5vO fglQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718877601; x=1719482401; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/iZzAiTQ5UNxV0/HtKdwOhMREms4rHsGBjYD5hM252w=; b=UadjrwNNCTDoOVZXPbQdP4lSAOWfX2y3DOy7FWLtLJLcHN2WdAve1/CvWX5q1x8GQI aEY3W5zsUXkDYPtVFIYwUD+ruuCl/LQxZhmvjCBRvGIHXQVzz5nC1NJy/bw5hJPWGwBZ 2efR/PdIKsQEp7buaTKRs8A+CCOm3I/j6mu5i1UqnUgrxZ5Osn0fJJl7y4g8y+19jwpJ tzUJQ6HqTpkRAdK5xF+WVwHHy7WGS5hVa/einOkWZlqRFTFgMwIIq+mthnMkeRsVqXnC WpLvgTSgvHqDfKikswG6T4WpeSIh6lDyQI/MUciwoIpbWgHBbLLUcyQpWh2b7LghcmV2 vRWw== X-Forwarded-Encrypted: i=1; AJvYcCVVWdjfsrp4wLoVn/SCih11E7ljtMap3Ic7pmJLWdCHPQgK1ElPa148Y6CJXiWRY22FdPzXHIJ4Bjd5mAht4TiZgk0NkTi+TJZuqGXQOozt3mwmi/0aLDqkMIQsf6GDXNUBmNGF9TmJwHqz+HtlX5ccBaF4lZ4g2SmxlWJ5LtUc/sErRFBrZpbLFueJwtI4/JIxGexykJgk4/cqF8xiTUPE/F6RJRvo X-Gm-Message-State: AOJu0YyfR0nwNwJmy9QuzhCAjSnf15xlV2UghoEeYlLuFMRbL65J+c7A bzlzPfvDwPBeKDkigRdDeo5JRBEO6Biw83TLd88V2o0m7sUI9/C0eeMFMtBLlxRQ9qyuPXGeru0 zCyvUbDo9FLySdK3UWn4wz1C5Now= X-Google-Smtp-Source: AGHT+IE/souHVrwkNI4H0SszQxPS242fjmLmxDj1CUeCpa2GYkt+I5sMR/FDRRdD3aYX9PRPh+0ikGTF07PKZIxciXM= X-Received: by 2002:a25:dc51:0:b0:dff:2bae:a0f7 with SMTP id 3f1490d57ef6-e02be20b9c1mr4819358276.47.1718877600660; Thu, 20 Jun 2024 03:00:00 -0700 (PDT) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240613091721.525266-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20240613091721.525266-4-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: From: "Lad, Prabhakar" Date: Thu, 20 Jun 2024 10:59:18 +0100 Message-ID: Subject: Re: [RFC PATCH v2 3/3] mmc: renesas_sdhi: Add support for RZ/V2H(P) SoC To: Biju Das Cc: Wolfram Sang , "linux-mmc@vger.kernel.org" , Fabrizio Castro , Conor Dooley , "devicetree@vger.kernel.org" , Ulf Hansson , Magnus Damm , Rob Herring , Krzysztof Kozlowski , Geert Uytterhoeven , Prabhakar Mahadev Lad , "linux-renesas-soc@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Biju, On Thu, Jun 20, 2024 at 10:49=E2=80=AFAM Biju Das wrote: > > Hi Prabhakar, > > > -----Original Message----- > > From: Lad, Prabhakar > > Subject: Re: [RFC PATCH v2 3/3] mmc: renesas_sdhi: Add support for RZ/V= 2H(P) SoC > > > > Hi Biju, > > > > On Thu, Jun 20, 2024 at 10:30=E2=80=AFAM Biju Das wrote: > > > > > > Hi Wolfram, Prabhakar, > > > > > > > -----Original Message----- > > > > From: Wolfram Sang > > > > Sent: Thursday, June 20, 2024 8:40 AM > > > > Subject: Re: [RFC PATCH v2 3/3] mmc: renesas_sdhi: Add support for > > > > RZ/V2H(P) SoC > > > > > > > > Hi Prabhakar, > > > > > > > > > I did give it a try with platform_driver_probe() and failed. > > > > > > > > Ok, thanks for trying nonetheless! > > > > > > > > > - Firstly I had to move the regulator node outside the SDHI node > > > > > for > > > > > platform_driver_probe() to succeed or else it failed with -ENODEV > > > > > (at > > > > > https://elixir.bootlin.com/linux/latest/source/drivers/base/platf= o > > > > > rm.c > > > > > #L953) > > > > > > > > This makes sense to me because it is just a "regular" regulator. > > > > > > > > > - In Renesas SoCs we have multiple instances of SDHI, the problem > > > > > being for each instance we are calling platform_driver_probe(). > > > > > Which causes a problem as the regulator node will use the first d= evice. > > > > > > > > I see... we would need a reg property to differentiate between the > > > > internal regulators but that is already used by the parent SDHI nod= e. > > > > > > > > Okay, so let's scrap that idea. However, we need to ensure that we > > > > can still have an external regulator. Seeing the bindings, it looks > > > > like you enable the internal regulator with the "vqmmc- r9a09g057-r= egulator" > > > > property? I wonder now if we can simplify this to an > > > > "use-internal-regulator" property because we have 'compatible' alre= ady to differentiate? Needs > > advice from DT maintainers, probably. > > > > > > Why this cannot be modelled as a regular "regulator" as a child devic= e of SDHI device? > > > > > The current implementation does implement the regulator as a child devi= ce of the sdhi node [0] > > itself. > > > > Wolfram was suggesting to have the regulator outside and use platform_d= river_probe(), which caused > > an issue as mentioned above. > > You, mean standalone node with a device compatible for each SDHI device n= odes(Assuming 3 sdhi devices)? > Yep. > 3 SDHI devices nodes(stand alone) + 3 regulator device nodes (stand alone= ) ? > This one (since as per the HW we have three SDHI instances and 3 internal regulators) so we need to describe the same in DT. Cheers, Prabhakar