devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Prabhakar Lad <prabhakar.csengg@gmail.com>
To: Hebbar Gururaja <gururaja.hebbar@ti.com>
Cc: akpm@linux-foundation.org, a.zummo@towertech.it,
	davinci-linux-open-source@linux.davincidsp.com,
	linux@arm.linux.org.uk, rtc-linux@googlegroups.com,
	linux-doc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
	linux-kernel@vger.kernel.org, rob.herring@calxeda.com,
	zonque@gmail.com, rob@landley.net, grant.likely@linaro.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] rtc: omap: add rtc wakeup support to alarm events
Date: Fri, 31 May 2013 12:20:39 +0530	[thread overview]
Message-ID: <CA+V-a8tpPV35Z22YCNKOvCP36+v1sF8+9Fiy_Wrk4T-iCVv4nw@mail.gmail.com> (raw)
In-Reply-To: <1369982005-8572-3-git-send-email-gururaja.hebbar@ti.com>

Hi Gururaja,

Thanks for the patch.

On Fri, May 31, 2013 at 12:03 PM, Hebbar Gururaja
<gururaja.hebbar@ti.com> wrote:
> On some platforms (like AM33xx), a special register (RTC_IRQWAKEEN)
[snip]
>  - ti,wakeup_capable: Inform the rtc driver that this module is wake-up
>    capable so that rtcwake and suspend tests can work.
> +- ti,has_irq_wake_enb: Inform rtc driver that this module has a a
same comment applies here as well.
s/has a a/ has a

> +  special register to enable Wakeup feature for Alarm events.
>
>  Example:
>
> diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c
> index 000a02f..5e9c0dd 100644
> --- a/drivers/rtc/rtc-omap.c
> +++ b/drivers/rtc/rtc-omap.c
> @@ -72,6 +72,8 @@
>  #define OMAP_RTC_KICK0_REG             0x6c
>  #define OMAP_RTC_KICK1_REG             0x70
>
> +#define OMAP_RTC_IRQWAKEEN             0x7C
> +
why not have the hex values in smaller case as done in the rest of the file ?

Regards,
--Prabhakar Lad

  reply	other threads:[~2013-05-31  6:50 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-31  6:33 [PATCH 0/2] rtc: rtc-omap: add support for DT wakeup & alarm events Hebbar Gururaja
     [not found] ` <1369982005-8572-1-git-send-email-gururaja.hebbar-l0cyMroinI0@public.gmane.org>
2013-05-31  6:33   ` [PATCH 1/2] rtc: omap: add option to indicate wakeup support through DT Hebbar Gururaja
2013-05-31  6:44     ` Prabhakar Lad
     [not found]       ` <CA+V-a8vAM_4qC20Fpipu3tROs65dERoFgV-ypyJh336rir-0EQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-05-31  6:46         ` Hebbar, Gururaja
2013-05-31 17:48     ` Kevin Hilman
     [not found]       ` <87wqqf11nw.fsf-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-06-04  9:48         ` Hebbar, Gururaja
2013-05-31  6:33 ` [PATCH 2/2] rtc: omap: add rtc wakeup support to alarm events Hebbar Gururaja
2013-05-31  6:50   ` Prabhakar Lad [this message]
2013-05-31 17:41   ` Kevin Hilman
     [not found]     ` <87a9nb2gjh.fsf-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-06-04  9:39       ` Hebbar, Gururaja
2013-06-10 11:25       ` Hebbar, Gururaja
2013-06-13  9:39     ` Hebbar, Gururaja
2013-06-13 22:21       ` Kevin Hilman
     [not found]         ` <87k3lxabyg.fsf-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-06-14 11:38           ` Hebbar, Gururaja

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+V-a8tpPV35Z22YCNKOvCP36+v1sF8+9Fiy_Wrk4T-iCVv4nw@mail.gmail.com \
    --to=prabhakar.csengg@gmail.com \
    --cc=a.zummo@towertech.it \
    --cc=akpm@linux-foundation.org \
    --cc=davinci-linux-open-source@linux.davincidsp.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@linaro.org \
    --cc=gururaja.hebbar@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=rob.herring@calxeda.com \
    --cc=rob@landley.net \
    --cc=rtc-linux@googlegroups.com \
    --cc=zonque@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).