Re: [PATCH 13/13] arm64: dts: renesas: rzt2h/rzn2h: Enable SD card slot

["Lad, Prabhakar" <prabhakar.csengg@gmail.com>]

Hi Geert,

Thank you for the review.

On Mon, Aug 18, 2025 at 5:03 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Prabhakar,
>
> On Tue, 12 Aug 2025 at 22:04, Prabhakar <prabhakar.csengg@gmail.com> wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > Enable SD card slot which is connected to SDHI0 on the RZ/T2H and
> > RZ/N2H EVKs.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Thanks for your patch!
>
> > --- a/arch/arm64/boot/dts/renesas/rzt2h-n2h-evk-common.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/rzt2h-n2h-evk-common.dtsi
>
> > @@ -104,6 +116,35 @@ sd0-emmc-ctrl-pins {
> >                 };
> >         };
> >
> > +#if SD0_SD
> > +       sdhi0-pwen-hog {
> > +               gpio-hog;
> > +               gpios = <RZT2H_GPIO(2, 5) GPIO_ACTIVE_HIGH>;
> > +               output-high;
> > +               line-name = "SD0_PWEN";
> > +       };
> > +#endif
> > +
> > +       sdhi0_sd_pins: sd0-sd-group {
> > +               sd0-sd-data-pins {
>
> No need for repeated sd0-sd-prefixes in the subnodes.
>
Ok, I will drop it.

> > +                       pinmux = <RZT2H_PORT_PINMUX(12, 2, 0x29)>, /* SD0_DATA0 */
> > +                                <RZT2H_PORT_PINMUX(12, 3, 0x29)>, /* SD0_DATA1 */
> > +                                <RZT2H_PORT_PINMUX(12, 4, 0x29)>, /* SD0_DATA2 */
> > +                                <RZT2H_PORT_PINMUX(12, 5, 0x29)>, /* SD0_DATA3 */
> > +                                <RZT2H_PORT_PINMUX(12, 6, 0x29)>, /* SD0_DATA4 */
> > +                                <RZT2H_PORT_PINMUX(12, 7, 0x29)>, /* SD0_DATA5 */
> > +                                <RZT2H_PORT_PINMUX(13, 0, 0x29)>, /* SD0_DATA6 */
> > +                                <RZT2H_PORT_PINMUX(13, 1, 0x29)>; /* SD0_DATA7 */
> > +               };
>
> SDcard uses only DATA0-3?
>
Agreed, I will drop the rest.

Cheers,
Prabhakar

> > +
> > +               sd0-sd-ctrl-pins {
> > +                       pinmux = <RZT2H_PORT_PINMUX(12, 0, 0x29)>, /* SD0_CLK */
> > +                                <RZT2H_PORT_PINMUX(12, 1, 0x29)>, /* SD0_CMD */
> > +                                <RZT2H_PORT_PINMUX(22, 5, 0x29)>, /* SD0_CD */
> > +                                <RZT2H_PORT_PINMUX(22, 6, 0x29)>; /* SD0_WP */
> > +               };
> > +       };
> > +
> >  #if SD1_MICRO_SD
> >         sdhi1-pwen-hog {
> >                 gpio-hog;
>
> The rest LGTM.
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds