From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65E54C433F5 for ; Fri, 29 Oct 2021 23:25:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3D81A60FED for ; Fri, 29 Oct 2021 23:25:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231579AbhJ2X1j (ORCPT ); Fri, 29 Oct 2021 19:27:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229546AbhJ2X1j (ORCPT ); Fri, 29 Oct 2021 19:27:39 -0400 Received: from mail-yb1-xb30.google.com (mail-yb1-xb30.google.com [IPv6:2607:f8b0:4864:20::b30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 112E6C061570 for ; Fri, 29 Oct 2021 16:25:10 -0700 (PDT) Received: by mail-yb1-xb30.google.com with SMTP id v138so22512142ybb.8 for ; Fri, 29 Oct 2021 16:25:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HBomj5H0QcXkbdufc+5bLoY1mf3VAHsbJiUVRwMaV2g=; b=lhT4g/NQepOEg+S71HTLuSq/0DHZyxu2YRwGdv9vGMHVpGBrTBpnthl4qHdhhfO/M2 l6wXa5TPx9uDYwyQSHqgsng0g3sJEW88/mK4yI+ff3H+4rdXPsGLTTycABCFKGYSKB0A IkC82mCkMOves8b3SVfnwKdOi1vnMkMD/bjY8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HBomj5H0QcXkbdufc+5bLoY1mf3VAHsbJiUVRwMaV2g=; b=zc0MBVnQmSPA3LtxqFJqClkCiOYAWIiZi0aMPfAnz9nOI63HysI2Ho5edckwaN2OZs bqpIFZYjXfNwTKRP5+5V5n+4pJw5QaKQf9iIGd+n1xq6Be37iKjgbEoLLhqkR429b6ZK kFx/3G8HXR00IuTccsi0u5ie+s7ivlB70Tcra7DKM2NN6rC9bb9nRXiLV5TxRNcsL8Rb EGoZrmaPvL2u2U9PaQhZ1CZD6+pjgOZ52Jjy979kr4Y9dadyQ73BLhY1FQbmI9ZAmDtw GapnOl0XqDndQelTtIVHqj3veyPmcI919bRxKzNDK3dHNZ85f54JYOdiS+OyHCNSNsQz darQ== X-Gm-Message-State: AOAM5305wFQQZasr5RI2lDfV8UqGTXRG6vD1IvmsJZtlIPfiRgrr6zts uQ0yES749vOMDlZiKlRQLDicVRkBvOF4YV6vt8f5PA== X-Google-Smtp-Source: ABdhPJziFKeWh57r/DG62iT/OHhEcs3mziCzQKeF4x8e/nYoq91bEZZ/Kfywf/H9n8Sfj+zXp7ercb8RFW0U8/PNaMY= X-Received: by 2002:a25:ea48:: with SMTP id o8mr14784901ybe.14.1635549909358; Fri, 29 Oct 2021 16:25:09 -0700 (PDT) MIME-Version: 1.0 References: <20211029152647.v3.1.Ie17e51ad3eb91d72826ce651ca2786534a360210@changeid> <20211029152647.v3.2.If23c83a786fc4d318a1986f43803f22b4b1d82cd@changeid> In-Reply-To: From: Philip Chen Date: Fri, 29 Oct 2021 16:24:58 -0700 Message-ID: Subject: Re: [PATCH v3 2/4] arm64: dts: sc7180: Specify "data-lanes" for DSI host output To: Stephen Boyd Cc: LKML , dianders@chromium.org, Andy Gross , Bjorn Andersson , Rob Herring , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Stephen, On Fri, Oct 29, 2021 at 4:16 PM Stephen Boyd wrote: > > Quoting Philip Chen (2021-10-29 15:27:41) > > MSM DSI host driver actually parses "data-lanes" in DT and compare > > it with the number of DSI lanes the bridge driver sets for > > mipi_dsi_device. So we need to always specify "data-lanes" for the > > DSI host output. As of now, "data-lanes" is added to ti-sn65dsi86 dts > > fragment, but missing in parade-ps8640 dts fragment, which requires > > a fixup. > > I don't see data-lanes required in the schema, and > dsi_host_parse_lane_data() seems happy to continue without it. I do see > that num_data_lanes isn't set though. Does this patch fix it? The problem I see is from dsi_host_attach(). If there is no "data-lanes" in DT, num_data_lanes would be 0. Then dsi_host_attach() would return -EINVAL. > > ----8<---- > diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c > b/drivers/gpu/drm/msm/dsi/dsi_host.c > index e269df285136..f6fba07220e5 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi_host.c > +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c > @@ -1696,6 +1696,7 @@ static int dsi_host_parse_lane_data(struct > msm_dsi_host *msm_host, > if (!prop) { > DRM_DEV_DEBUG(dev, > "failed to find data lane mapping, using default\n"); > + msm_host->num_data_lanes = 4; > return 0; > } I haven't tried. But I think it can fix the problem I described above. Would you like to send it as a separate patch? Or I can do it.