From: "Jérôme de Bretagne" <jerome.debretagne@gmail.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Dale Whinham <daleyo@gmail.com>,
Johannes Berg <johannes@sipsolutions.net>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jeff Johnson <jjohnson@kernel.org>,
Jeff Johnson <jeff.johnson@oss.qualcomm.com>,
linux-wireless@vger.kernel.org, devicetree@vger.kernel.org,
ath12k@lists.infradead.org, linux-kernel@vger.kernel.org,
Lingbo Kong <quic_lingbok@quicinc.com>
Subject: Re: [PATCH 7/9 RFC] dt-bindings: wireless: ath12k: Add disable-rfkill property
Date: Tue, 15 Jul 2025 01:26:48 +0200 [thread overview]
Message-ID: <CA+kEDGFR3FB=ead50kFBAL23-1dXo-LOMqhT7f=WecNMf_MaNg@mail.gmail.com> (raw)
In-Reply-To: <prrra3lon2p4pugkgeytf5ow5wls62lfdnwcdykztw3qzwity2@d26aqh6wdyln>
On Mon. Jul 15, 2025 at 00:33, Dmitry Baryshkov
<dmitry.baryshkov@oss.qualcomm.com> wrote :
>
> On Mon, Jul 14, 2025 at 06:35:43PM +0100, Dale Whinham wrote:
> > From: Jérôme de Bretagne <jerome.debretagne@gmail.com>
> >
> > Document the disable-rfkill property.
>
> Why? What does it mean? Why are you describing Linux driver firmware in
> the DT?
rfkill should be disabled according to the Surface Pro 11's DSDT.
https://lore.kernel.org/all/20250113074810.29729-3-quic_lingbok@quicinc.com/
has added support to read the ACPI bitflag when ACPI is supported.
The idea was to expose one specific feature (DISABLE_RFKILL_BIT) for
devices described with a DT, so that the feature can be disabled.
> >
> > Signed-off-by: Jérôme de Bretagne <jerome.debretagne@gmail.com>
> > Signed-off-by: Dale Whinham <daleyo@gmail.com>
> > ---
> > .../devicetree/bindings/net/wireless/qcom,ath12k.yaml | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml
> > index 9e557cb838c7..f15b630fb034 100644
> > --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml
> > +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml
> > @@ -48,6 +48,9 @@ properties:
> > vddpcie1p8-supply:
> > description: VDD_PCIE_1P8 supply regulator handle
> >
> > + disable-rfkill:
> > + type: boolean
> > +
> > required:
> > - compatible
> > - reg
> > --
> > 2.50.1
> >
>
> --
> With best wishes
> Dmitry
next prev parent reply other threads:[~2025-07-14 23:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-14 17:35 [PATCH 0/9] Microsoft Surface Pro 11 support Dale Whinham
2025-07-14 17:35 ` [PATCH 1/9] dt-bindings: arm: qcom: Document Microsoft Surface Pro 11 Dale Whinham
2025-07-15 3:58 ` Rob Herring (Arm)
2025-07-14 17:35 ` [PATCH 2/9] dt-bindings: display: panel: samsung,atna30dw01: document ATNA30DW01 Dale Whinham
2025-07-14 17:41 ` Doug Anderson
2025-07-15 3:58 ` Rob Herring (Arm)
2025-07-15 17:26 ` Doug Anderson
2025-07-14 17:35 ` [PATCH 5/9] arm64: dts: qcom: Add support for Surface Pro 11 Dale Whinham
2025-07-14 17:35 ` [PATCH 7/9 RFC] dt-bindings: wireless: ath12k: Add disable-rfkill property Dale Whinham
2025-07-14 22:33 ` Dmitry Baryshkov
2025-07-14 23:26 ` Jérôme de Bretagne [this message]
2025-07-15 4:02 ` Rob Herring
2025-07-14 17:35 ` [PATCH 9/9 RFC] arm64: dts: qcom: x1e80100-denali: Disable rfkill for wifi0 Dale Whinham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+kEDGFR3FB=ead50kFBAL23-1dXo-LOMqhT7f=WecNMf_MaNg@mail.gmail.com' \
--to=jerome.debretagne@gmail.com \
--cc=ath12k@lists.infradead.org \
--cc=conor+dt@kernel.org \
--cc=daleyo@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=jeff.johnson@oss.qualcomm.com \
--cc=jjohnson@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_lingbok@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).