From: Dave Martin <dave.martin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
Arvid Brodin <arvid.brodin-AM1FMPraTHU@public.gmane.org>,
Dave Martin <dave.martin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH 1/2] isp1760: Make probing via device tree non-powerpc-specific
Date: Wed, 14 Sep 2011 15:10:54 +0100 [thread overview]
Message-ID: <CA+wbFdeLCOh5DdcPkWhmtsbchn7BYvLj5t+0_KXfH_iV_o6OuA@mail.gmail.com> (raw)
In-Reply-To: <1316008633-31009-2-git-send-email-dave.martin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
On Wed, Sep 14, 2011 at 2:57 PM, Dave Martin <dave.martin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
> This patch just replaces the (presumably historical) CONFIG_OF_PPC
Apologies, it looks like a script ate part of the commit message for
this commit.
It should read:
isp1760: Make probing via device tree non-powerpc-specific
This patch just replaces the (presumably historical) CONFIG_OF_PPC
ifdefs with CONFIG_OF, and supplies some missing includes.
I can fix that when reposting, but feedback on the patch is still
appreciated in the meantime.
Thanks
---Dave
>
> Signed-off-by: Dave Martin <dave.martin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> Acked-by: Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>
> ---
> drivers/usb/host/isp1760-if.c | 10 ++++++----
> 1 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/host/isp1760-if.c b/drivers/usb/host/isp1760-if.c
> index 7ee3005..69ee32c 100644
> --- a/drivers/usb/host/isp1760-if.c
> +++ b/drivers/usb/host/isp1760-if.c
> @@ -17,16 +17,18 @@
>
> #include "isp1760-hcd.h"
>
> -#ifdef CONFIG_PPC_OF
> +#ifdef CONFIG_OF
> #include <linux/of.h>
> #include <linux/of_platform.h>
> +#include <linux/of_address.h>
> +#include <linux/of_irq.h>
> #endif
>
> #ifdef CONFIG_PCI
> #include <linux/pci.h>
> #endif
>
> -#ifdef CONFIG_PPC_OF
> +#ifdef CONFIG_OF
> static int of_isp1760_probe(struct platform_device *dev)
> {
> struct usb_hcd *hcd;
> @@ -396,7 +398,7 @@ static int __init isp1760_init(void)
> ret = platform_driver_register(&isp1760_plat_driver);
> if (!ret)
> any_ret = 0;
> -#ifdef CONFIG_PPC_OF
> +#ifdef CONFIG_OF
> ret = platform_driver_register(&isp1760_of_driver);
> if (!ret)
> any_ret = 0;
> @@ -416,7 +418,7 @@ module_init(isp1760_init);
> static void __exit isp1760_exit(void)
> {
> platform_driver_unregister(&isp1760_plat_driver);
> -#ifdef CONFIG_PPC_OF
> +#ifdef CONFIG_OF
> platform_driver_unregister(&isp1760_of_driver);
> #endif
> #ifdef CONFIG_PCI
> --
> 1.7.4.1
>
>
--
Dave Martin <dave.martin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Linaro Kernel Working Group
--
http://www.linaro.org/ -- Open source software for ARM SoCs
http://www.facebook.com/pages/Linaro
http://twitter.com/#!/linaroorg
http://www.linaro.org/linaro-blog/
next prev parent reply other threads:[~2011-09-14 14:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-14 13:57 [PATCH 0/2] isp1760: Allow device-tree-based probing on non-powerpc architectures Dave Martin
[not found] ` <1316008633-31009-1-git-send-email-dave.martin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-09-14 13:57 ` [PATCH 1/2] isp1760: Make probing via device tree non-powerpc-specific Dave Martin
[not found] ` <1316008633-31009-2-git-send-email-dave.martin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-09-14 14:10 ` Dave Martin [this message]
2011-09-14 15:43 ` Grant Likely
2011-09-14 13:57 ` [PATCH 2/2] isp1760: Fix endianness-sensitivity in of_isp1760_probe() Dave Martin
[not found] ` <1316008633-31009-3-git-send-email-dave.martin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-09-14 15:46 ` Grant Likely
2011-09-14 19:12 ` Sergei Shtylyov
[not found] ` <4E70FCB9.4050907-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
2011-09-15 8:53 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+wbFdeLCOh5DdcPkWhmtsbchn7BYvLj5t+0_KXfH_iV_o6OuA@mail.gmail.com \
--to=dave.martin-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=arvid.brodin-AM1FMPraTHU@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).