From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f181.google.com (mail-yb1-f181.google.com [209.85.219.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A32A1C6B4 for ; Sun, 14 Apr 2024 23:13:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713136423; cv=none; b=ZBueHryDsV+QlQhPM3hHOZ/00Hb0/bdIN8wYhPoBci4uNGrh2UkZkLZHlkp5fpX6WVxhkDaMdxyJXrfvLEETGIxVymJhfkwzBNMPqDCc3Rs11aFW0us+BT3kYHfbaWSzc8t6YcFRpokZoDv6c/HNZP2rOlXeFk2vYhP14IZEJDo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713136423; c=relaxed/simple; bh=QMLfy/z4mNzK40DCutaIMBO2o0qIgTTudTT7w4FR7Lw=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=iMn6U1uvgFQmetJZxjYgjcz7T30hNhHftlr8jzsguQJwLmMbH/XyosS9xPeefHB7ACXeELBAVvh9y2MrUkRxqorFj/mnGBBMF5rj+/GAjw0Jlg7+1OouQuwfiKTepA+21XGobhM0xcO2M/0ICI64v5HAe/9bH6HnwSf1L97SW0s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=rNS0PpVs; arc=none smtp.client-ip=209.85.219.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rNS0PpVs" Received: by mail-yb1-f181.google.com with SMTP id 3f1490d57ef6-dc6cbe1ac75so1956694276.1 for ; Sun, 14 Apr 2024 16:13:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713136420; x=1713741220; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Pc13QrE+mcMLNyC+/9mJ9l2G8Lqrng5Jebsz9BpHb4g=; b=rNS0PpVs8WSj+IJV9gGvkhKbkLA0mdhUyeCP6vA1+g2EZkph1h7Y5R+UeVPKuM0IyD 0kd77m25UC4X38stNQAjV2kziMJ8r8GoMKU2JAuSX9Rtc3gzZBy7BS0yXaY80KDRdNjy /Xpp/r3Qi//KBXrXwENl7VF7IB7X8AgOo4zjZuOrRC7LNCR+DzF3MW+YPXB7Q64mWyzH 2ri2Klkmlfq0YXV13m5f8fv/h6b8rNOVSQa3/Tc5iOXHHnkewASzCou+EqaA9bSgRDX4 OlpiZMn1970hWMxZEapM77Ai4hk92wR1LN5ZJR5F3lwsJnzN65KEsMgYsRhWIsu67E85 s5bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713136420; x=1713741220; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Pc13QrE+mcMLNyC+/9mJ9l2G8Lqrng5Jebsz9BpHb4g=; b=FkpVxFNTSylqQ3yQScBy/08b3tJOT2Ww4o6r21UXip+G2o4P81qjGdQ5vCYGYfpwYj qU/0azYIJaJk/Ktj/87qODBP93ymIC2m+m0Ei8pomPFt5oIuHVdEWoRKUTsdjoW96ud6 oOU6gGqVw3PPjtX6xbWyizIVgNTDi8TFne5I4b0O+6fR8uRS4gR6Y7wzaMeQEah8VP52 CZcQR2jRG7mkvhtkLg+4s/skmEf1RfJBmSP2/88eRephHmbXs4ctndqMYCTwo2C5EorG lUXMsOF6HbyuU2TKvCxCukbZtrvtW1IZHZBMn7L6iNXrvSRNXZDWjFGCX0woB6oyPI3I Qz4Q== X-Forwarded-Encrypted: i=1; AJvYcCXlXB1rqQ8raODkC/XGrqCNXBRrK6pbzqSnFS2IbLMK3kl3+dBjK6XJyUo4baxwdNl7Hsp9piLlEAMqucgs6CqvxqRrJNVEeObmWA== X-Gm-Message-State: AOJu0YwyWXt90fjFMHi72Stro0GZbVJXE3mueTSJx018EnEI6yo0mH3n RQbRUwF61W9mbTHcT238dp+YUTw/OoinsnV202bo4viSR1xbo+6FmN84iozPBxIeodm/HAPPbeb vhkkSZCNQQm7Mi8cm8MpYqw3zp/HGtMpU8AAYBA== X-Google-Smtp-Source: AGHT+IHMfnCixFavyGFnOFgqpnrQIq3w30uiJ2YS1tM9ZRsbn/sGrT2sUyDk/RDov0yEDrEAI1leaOZQraIrNUN8HWM= X-Received: by 2002:a25:c83:0:b0:de1:5656:ba49 with SMTP id 125-20020a250c83000000b00de15656ba49mr3740557ybm.16.1713136420215; Sun, 14 Apr 2024 16:13:40 -0700 (PDT) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240414-arm-psci-system_reset2-vendor-reboots-v2-0-da9a055a648f@quicinc.com> <20240414-arm-psci-system_reset2-vendor-reboots-v2-4-da9a055a648f@quicinc.com> In-Reply-To: <20240414-arm-psci-system_reset2-vendor-reboots-v2-4-da9a055a648f@quicinc.com> From: Dmitry Baryshkov Date: Mon, 15 Apr 2024 02:13:29 +0300 Message-ID: Subject: Re: [PATCH v2 4/4] arm64: dts: qcom: Add PSCI SYSTEM_RESET2 types for qcm6490-idp To: Elliot Berman Cc: Bjorn Andersson , Konrad Dybcio , Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Andy Yan , Lorenzo Pieralisi , Mark Rutland , Bartosz Golaszewski , Satya Durga Srinivasu Prabhala , Melody Olvera , Shivendra Pratap , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Florian Fainelli , linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" On Sun, 14 Apr 2024 at 22:32, Elliot Berman wrote: > > Add nodes for the vendor-defined system resets. "bootloader" will cause > device to reboot and stop in the bootloader's fastboot mode. "edl" will > cause device to reboot into "emergency download mode", which permits > loading images via the Firehose protocol. > > Co-developed-by: Shivendra Pratap > Signed-off-by: Shivendra Pratap > Signed-off-by: Elliot Berman > --- > arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts > index e4bfad50a669..a966f6c8dd7c 100644 > --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts > +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts > @@ -126,6 +126,11 @@ debug_vm_mem: debug-vm@d0600000 { > }; > }; > > + psci { Please use a label instead. Otherwise it looks as if you are adding new device node. > + mode-bootloader = <0x10001 0x2>; > + mode-edl = <0 0x1>; > + }; > + > vph_pwr: vph-pwr-regulator { > compatible = "regulator-fixed"; > regulator-name = "vph_pwr"; > > -- > 2.34.1 > > -- With best wishes Dmitry