* [PATCH v1 0/1] Fix the way to get porch parameters
@ 2024-07-15 3:18 Zhaoxiong Lv
2024-07-15 3:18 ` [PATCH v1 1/1] drm/panel: boe-th101mb31ig002 : " Zhaoxiong Lv
2024-07-15 13:57 ` [PATCH v1 0/1] " Doug Anderson
0 siblings, 2 replies; 4+ messages in thread
From: Zhaoxiong Lv @ 2024-07-15 3:18 UTC (permalink / raw)
To: neil.armstrong, robh, krzysztof.kozlowski+dt, conor+dt, airlied,
mripard, dianders, hsinyi, awarnecke002, quic_jesszhan,
dmitry.baryshkov
Cc: dri-devel, devicetree, linux-kernel, Zhaoxiong Lv
The current driver can only obtain the porch parameters
of boe-th101mb31ig002. Modify it to obtain the porch
parameters of the panel currently being used.
Zhaoxiong Lv (1):
drm/panel: boe-th101mb31ig002 : Fix the way to get porch parameters
drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v1 1/1] drm/panel: boe-th101mb31ig002 : Fix the way to get porch parameters
2024-07-15 3:18 [PATCH v1 0/1] Fix the way to get porch parameters Zhaoxiong Lv
@ 2024-07-15 3:18 ` Zhaoxiong Lv
2024-07-15 11:32 ` Dmitry Baryshkov
2024-07-15 13:57 ` [PATCH v1 0/1] " Doug Anderson
1 sibling, 1 reply; 4+ messages in thread
From: Zhaoxiong Lv @ 2024-07-15 3:18 UTC (permalink / raw)
To: neil.armstrong, robh, krzysztof.kozlowski+dt, conor+dt, airlied,
mripard, dianders, hsinyi, awarnecke002, quic_jesszhan,
dmitry.baryshkov
Cc: dri-devel, devicetree, linux-kernel, Zhaoxiong Lv
The current driver can only obtain the porch parameters
of boe-th101mb31ig002. Modify it to obtain the porch
parameters of the panel currently being used.
Fixes: 24179ff9a2e4524 ("drm/panel: boe-th101mb31ig002 : Make it compatible with other panel.")
Signed-off-by: Zhaoxiong Lv <lvzhaoxiong@huaqin.corp-partner.google.com>
---
drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c b/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c
index b55cf80c5522..d4e4abd103bb 100644
--- a/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c
+++ b/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c
@@ -312,15 +312,14 @@ static int boe_th101mb31ig002_get_modes(struct drm_panel *panel,
struct boe_th101mb31ig002 *ctx = container_of(panel,
struct boe_th101mb31ig002,
panel);
+ const struct drm_display_mode *desc_mode = ctx->desc->modes;
struct drm_display_mode *mode;
- mode = drm_mode_duplicate(connector->dev,
- &boe_th101mb31ig002_default_mode);
+ mode = drm_mode_duplicate(connector->dev, desc_mode);
if (!mode) {
dev_err(panel->dev, "Failed to add mode %ux%u@%u\n",
- boe_th101mb31ig002_default_mode.hdisplay,
- boe_th101mb31ig002_default_mode.vdisplay,
- drm_mode_vrefresh(&boe_th101mb31ig002_default_mode));
+ desc_mode->hdisplay, desc_mode->vdisplay,
+ drm_mode_vrefresh(desc_mode));
return -ENOMEM;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] drm/panel: boe-th101mb31ig002 : Fix the way to get porch parameters
2024-07-15 3:18 ` [PATCH v1 1/1] drm/panel: boe-th101mb31ig002 : " Zhaoxiong Lv
@ 2024-07-15 11:32 ` Dmitry Baryshkov
0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2024-07-15 11:32 UTC (permalink / raw)
To: Zhaoxiong Lv
Cc: neil.armstrong, robh, krzysztof.kozlowski+dt, conor+dt, airlied,
mripard, dianders, hsinyi, awarnecke002, quic_jesszhan, dri-devel,
devicetree, linux-kernel
On Mon, 15 Jul 2024 at 06:19, Zhaoxiong Lv
<lvzhaoxiong@huaqin.corp-partner.google.com> wrote:
>
> The current driver can only obtain the porch parameters
> of boe-th101mb31ig002. Modify it to obtain the porch
> parameters of the panel currently being used.
>
> Fixes: 24179ff9a2e4524 ("drm/panel: boe-th101mb31ig002 : Make it compatible with other panel.")
>
> Signed-off-by: Zhaoxiong Lv <lvzhaoxiong@huaqin.corp-partner.google.com>
No empty line between Fixed and Sign-off-by
> ---
> drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c b/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c
> index b55cf80c5522..d4e4abd103bb 100644
> --- a/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c
> +++ b/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c
> @@ -312,15 +312,14 @@ static int boe_th101mb31ig002_get_modes(struct drm_panel *panel,
> struct boe_th101mb31ig002 *ctx = container_of(panel,
> struct boe_th101mb31ig002,
> panel);
> + const struct drm_display_mode *desc_mode = ctx->desc->modes;
> struct drm_display_mode *mode;
>
> - mode = drm_mode_duplicate(connector->dev,
> - &boe_th101mb31ig002_default_mode);
> + mode = drm_mode_duplicate(connector->dev, desc_mode);
> if (!mode) {
> dev_err(panel->dev, "Failed to add mode %ux%u@%u\n",
> - boe_th101mb31ig002_default_mode.hdisplay,
> - boe_th101mb31ig002_default_mode.vdisplay,
> - drm_mode_vrefresh(&boe_th101mb31ig002_default_mode));
> + desc_mode->hdisplay, desc_mode->vdisplay,
> + drm_mode_vrefresh(desc_mode));
> return -ENOMEM;
Please add a followup switching to drm_connector_helper_get_modes_fixed()
> }
>
> --
> 2.17.1
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 0/1] Fix the way to get porch parameters
2024-07-15 3:18 [PATCH v1 0/1] Fix the way to get porch parameters Zhaoxiong Lv
2024-07-15 3:18 ` [PATCH v1 1/1] drm/panel: boe-th101mb31ig002 : " Zhaoxiong Lv
@ 2024-07-15 13:57 ` Doug Anderson
1 sibling, 0 replies; 4+ messages in thread
From: Doug Anderson @ 2024-07-15 13:57 UTC (permalink / raw)
To: Zhaoxiong Lv
Cc: neil.armstrong, robh, krzysztof.kozlowski+dt, conor+dt, airlied,
mripard, hsinyi, awarnecke002, quic_jesszhan, dmitry.baryshkov,
dri-devel, devicetree, linux-kernel
Hi,
On Sun, Jul 14, 2024 at 8:18 PM Zhaoxiong Lv
<lvzhaoxiong@huaqin.corp-partner.google.com> wrote:
>
> The current driver can only obtain the porch parameters
> of boe-th101mb31ig002. Modify it to obtain the porch
> parameters of the panel currently being used.
>
> Zhaoxiong Lv (1):
> drm/panel: boe-th101mb31ig002 : Fix the way to get porch parameters
>
> drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
For future reference, if you're only posting one patch, there's no
need to send a cover letter (AKA patch #0).
-Doug
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-07-15 13:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-15 3:18 [PATCH v1 0/1] Fix the way to get porch parameters Zhaoxiong Lv
2024-07-15 3:18 ` [PATCH v1 1/1] drm/panel: boe-th101mb31ig002 : " Zhaoxiong Lv
2024-07-15 11:32 ` Dmitry Baryshkov
2024-07-15 13:57 ` [PATCH v1 0/1] " Doug Anderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).