From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55252C46467 for ; Sun, 27 Nov 2022 21:44:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229552AbiK0VoC (ORCPT ); Sun, 27 Nov 2022 16:44:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229693AbiK0VoB (ORCPT ); Sun, 27 Nov 2022 16:44:01 -0500 Received: from mail-yw1-x1135.google.com (mail-yw1-x1135.google.com [IPv6:2607:f8b0:4864:20::1135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 774D9A47D for ; Sun, 27 Nov 2022 13:44:00 -0800 (PST) Received: by mail-yw1-x1135.google.com with SMTP id 00721157ae682-3704852322fso88722057b3.8 for ; Sun, 27 Nov 2022 13:44:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Q3YJ8VN4qd/z1cevuuYf6BzrtIafu4RWyw6odYhJ3RM=; b=xl2aTicD/qKFHfHq+LzfroPQbYHSrzIEfeD2Ob6oEuWgU8WzZDTYs4L/9thbGXh5nm Xs6+ApXjhZJriEXHtYdizyyIiJd71ebrvCROaIpXiePzWb7fIUWM8kPUaxjgTTiEdM22 ncHVYNuOfFdE+ZrwOZWXR5gMWSoUNNYvXkZYhaxMjLGPrFLXYy8Dw4AoGi1IgTSev8eZ Bps1SUwAPz8bpOYMI0Ej8OYYRGQtRWqVnOfHBOlW9YpemZMlT8AEE4r3D+cTczzKp87i 39tAofYvg3XMb1auK6XP3i8sXQFXMN3BVyw+wQZ7+OcaQOPVD/L7CaBuVOyDGJNfrePE B1Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Q3YJ8VN4qd/z1cevuuYf6BzrtIafu4RWyw6odYhJ3RM=; b=KqkaFhe/xXuavRxJqECmOns5mqtalzx5JCJQIMUOEUpOQAks7G2w7fQmoxg1QmmtY6 OQwS2AKmfxsPsu/HgMvD+D1w3imfZ/ne5xUjMwnBaPHwOSoyIZ5BmNSrtoU2mhkGbgNi ljEfn0rm9CsqW3oyGnCRAofmyrggsCwjOHxYdXQeM37cVBynM/notDM4cdUkOMJNYb++ MhwETuQRyP56TqgV44lizyLByaKY+gWk94W3Kq6N8XklKASIeR/Bd4756ikSq5hx+1o6 Xplt1UMJVTcqVpcfMW+Kbk8O8ilna7S9ehQd4JRTGgSdFaCvwMwqd4IEkKgsf2nbkyCS NJQA== X-Gm-Message-State: ANoB5pnVRWNFW2eMxxK5zxvyOboVNi11vefJh6BU0ZDwOJWjfMuldDsg pt7YdLNjFRX0OJpmKl656fwRaagMiDcUNYGBKNsBwA== X-Google-Smtp-Source: AA0mqf66I8xq7rZ0bAaQt2cLk1BVbeeZsnMiNjpUCai1K5JbdH+J7KsZFasgMiyl2LhZUBDdGTtqrDTIudgq871HxEk= X-Received: by 2002:a81:520d:0:b0:3c0:c065:7608 with SMTP id g13-20020a81520d000000b003c0c0657608mr7161381ywb.378.1669585438656; Sun, 27 Nov 2022 13:43:58 -0800 (PST) MIME-Version: 1.0 References: <20221127181835.806410-1-luca@z3ntu.xyz> In-Reply-To: From: Dmitry Baryshkov Date: Sun, 27 Nov 2022 23:43:47 +0200 Message-ID: Subject: Re: [PATCH 1/2] dt-bindings: arm: qcom: Document oneplus,bacon device To: Krzysztof Kozlowski Cc: Luca Weiss , linux-arm-msm@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sun, 27 Nov 2022 at 23:30, Krzysztof Kozlowski wrote: > > On 27/11/2022 22:25, Dmitry Baryshkov wrote: > > On Sun, 27 Nov 2022 at 20:19, Luca Weiss wrote: > >> > >> Document the OnePlus One ("bacon") which is a smartphone based on the > >> Snapdragon 801 SoC. > >> > >> Also allow msm8974 devices to use qcom,msm-id and qcom,board-id. > > > > The patch itself is good. However it raised a broader question for me. > > Up to now all msm8974pro devices use qcom,msm8974 as a top-level > > compatibility string. Should it be changed to use pro-specific one > > (e.g. qcom,msm8974pro)? > > Yes, makes sense. Would you make the patch? -- With best wishes Dmitry