From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com [209.85.219.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22576811F1 for ; Tue, 16 Apr 2024 12:32:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713270736; cv=none; b=O6olN2lZwodxY6+2/oPuGa7IVCdTK1bxMjLYw4G3ATSuye4wO2ulF8QECRMdtzfqTXWT/VAiVsFUs8CTF8W4UwhJmG8tmqTT9zNel+tF5RIb9jKQuuv3Hw3LXVGF0DgEdQNf8Qu1J9xazpFz1ulEh2p5UhgQwnh1bRFzQsHz7wU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713270736; c=relaxed/simple; bh=Pt5/vGHuhGceeo+QpbsK2XpxTMgmfSIqSNFU1JiurME=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=MVeNnBxDoFKPhnMFS5l7nCiFhqSmWgdcd05tElWCE8It0qIovx/In+0eA51dkKDGMrZksQHsR7ieV3OQ/oD17bxw1c67pdEvu/hcl6VBLkhtUtk3laW47pB4HMYn3LurlF3TblYGBYWUnJYlj88shpuvR4mo9ziGHp0tKVPQchA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=sxPlLjZ5; arc=none smtp.client-ip=209.85.219.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="sxPlLjZ5" Received: by mail-yb1-f182.google.com with SMTP id 3f1490d57ef6-dcbd1d4904dso4255297276.3 for ; Tue, 16 Apr 2024 05:32:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713270734; x=1713875534; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=qFzNumwLL/PShEK3mtGPwjGln1YmU4ULHeA3GQnXIh8=; b=sxPlLjZ5GCGhLrxd9XBWpj/89hu9GSM/WsGPuHEsYI6fuMPDZvBklz9i9rm3A//m7N BqNqVOCg32CkqQwHMuNYLcmuTUAAqqBRXBRFRe7gsknq7Z2H2QhZ2m+kaEXT2/kaS0YS 3ApxjEXH51bBG7n1LdHPFQbAcaeByGEmuITFBRUa94BED/cdqkknpyepqqkqdVrsQRiO 8eTdErEl/tkZ+NZoldn1p4EkrCIYW2YuCnU9wHkxYyfnRZZLhOZG6Na4pCCYM0/XyLX1 8gf6iiqayylIGEC6smp/9tC3508NQHncAL8vKxl2S6yxLeq6UBw/Tm4aPfz+SuxMxsuw dQEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713270734; x=1713875534; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qFzNumwLL/PShEK3mtGPwjGln1YmU4ULHeA3GQnXIh8=; b=PinMVW59Auor99EiIcvIfS0XHlASleKuVRsQX6IUmCluh1w3aFZYTjab+rBnvYxADN DjrwHyahA+fg3a4VOpJweOavumCw42JIkmV7+IDS/stT5eBbb69JrsYRjmljNJ5kijYc AXiyOa70pwPCaCA6TiQkNORCEmOYungY6DmvWuuHCMud2ROYvfO1m0IyG5AAo8n9+At6 B5souLlAs6q3M6WXl1qhTbv8k1ekzbfzj2YcamXZTAy9HI1EYyyKVoA7AFSpKnuR7mJl C7lCgwrgzOFLGPFJe54pYpb29aU6D0LebiDB9hoDS4/OA+CBlmR12Rx0C6ZeN7X3UEK1 j1NQ== X-Forwarded-Encrypted: i=1; AJvYcCWyPtXrf1IGF2JZ8OttvOWaOdbqHLtJEEHryFn1aOheiRo83OgkWDqtQ8vwwcD1ARaUKnJvFvvCqoY5b3wSeijqv1Efff1BejpOWw== X-Gm-Message-State: AOJu0YxCT51MbM20f5zUxZTeB+AZu4TpRwVknWx5MgTAQ6J0tWkCIrvq t7DmG6GK4AUtGkiOKB15k2+2YHQDs9r/2ODr2q4BR+nsqe22MQwrcWgs8/YBfBPMqIsx9YCvdBm lHAA6fZsxsXjEXNVV26AH9UI7FBSMUc/vi47Sew== X-Google-Smtp-Source: AGHT+IGV27KS53nGXMmiHjntrt3Z5nGpbgyi0jBS2Pa+b7xJatvlhEtb1vxhnn5pvUEhuRd3C8c95o+slvde3TTPid0= X-Received: by 2002:a25:1687:0:b0:de0:fb80:5c6a with SMTP id 129-20020a251687000000b00de0fb805c6amr10814478ybw.60.1713270734122; Tue, 16 Apr 2024 05:32:14 -0700 (PDT) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240414-arm-psci-system_reset2-vendor-reboots-v2-0-da9a055a648f@quicinc.com> <20240414-arm-psci-system_reset2-vendor-reboots-v2-2-da9a055a648f@quicinc.com> In-Reply-To: From: Dmitry Baryshkov Date: Tue, 16 Apr 2024 15:32:02 +0300 Message-ID: Subject: Re: [PATCH v2 2/4] dt-bindings: arm: Document reboot mode magic To: Sudeep Holla Cc: Elliot Berman , Bjorn Andersson , Konrad Dybcio , Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Andy Yan , Lorenzo Pieralisi , Mark Rutland , Bartosz Golaszewski , Satya Durga Srinivasu Prabhala , Melody Olvera , Shivendra Pratap , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Florian Fainelli , linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" On Tue, 16 Apr 2024 at 12:30, Sudeep Holla wrote: > > On Sun, Apr 14, 2024 at 12:30:25PM -0700, Elliot Berman wrote: > > Add bindings to describe vendor-specific reboot modes. Values here > > correspond to valid parameters to vendor-specific reset types in PSCI > > SYSTEM_RESET2 call. > > > > IIUC, PSCI SYSTEM_RESET will be always supported, so the choice of using > SYSTEM_RESET2 sounds like a system policy and must not have any information > in the device tree. All required support from PSCI is discoverable and > the policy choice must be userspace driven. That's my opinion. Well, we are talking about the vendor-specific resets, which are not discoverable. The spec defines them as "implementation defined". For example, PCSI spec doesn't define a way to add "reset to bootloader" or "reset to recovery" kinds of resets. I think the bindings at least should make it clear that the vendor bit it being set automatically. I won't comment whether this is a good decision or not. -- With best wishes Dmitry