From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9957CCA48B for ; Sun, 24 Jul 2022 18:55:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231656AbiGXSzd (ORCPT ); Sun, 24 Jul 2022 14:55:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229887AbiGXSzc (ORCPT ); Sun, 24 Jul 2022 14:55:32 -0400 Received: from mail-qv1-xf30.google.com (mail-qv1-xf30.google.com [IPv6:2607:f8b0:4864:20::f30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91174638A for ; Sun, 24 Jul 2022 11:55:31 -0700 (PDT) Received: by mail-qv1-xf30.google.com with SMTP id x8so5221661qvo.13 for ; Sun, 24 Jul 2022 11:55:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=BZIDWbd+e5/Q1G0dFyLVjy7eyY4n93CGPNpfz9ufq8k=; b=Y/x3X31uJTRvN69iA8JzEhHsItKIPMJZshfa+bd/jj0BgkTh5+YrF4nH/331x6eMQ8 ZimP5N8WljYAKCHUHQXUPtfODti54bLmHHssHC3psGmOQ1x2wL3vQWNzdKDe5wdqY3Sa tEReokYrGMZF6VWR0PXKEKEnxrWKpGqOKOII6pOM7iD6OEh9wHH6gbtJlxOa0w+HDBvK 9WfCPqQgstBgL0M8Y8v4nLRaNoDtXdvFpPH7qjMoFZtUSAk55b9biOIBVAKndTmQ/5YB 3f1zBf5/kDr20EFdT3GvoeW7mw+Zi37ltG/fe8mnf4SIy6WKBXP/Shnia+sPWYXMFBKw SlMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=BZIDWbd+e5/Q1G0dFyLVjy7eyY4n93CGPNpfz9ufq8k=; b=zowk2pCCFh4KBz8B1hLOKBNKOh4D5p23PrYV18STlHYWfBSUQrCbLP0psQek4cbddC QeGhbFHlRAOq0yIMOgtE02R5CCc6zhfJemUNr5kq3H1zn7zlfR3cdWso4TILrXrtx+gf U5yjRCTcA/kXff4uE81dgE+mgmcFWnp1F8pqABe8GMCX13NeuUewDS462qHhIkB7S4Ho mV+j7iAqrUTI1VwazWpoPyviyd1nPRSbk4DPIJwbqS0CU0hXjWqD/x/Yyp/j0cU2ES7C 6+HIycQVb+kcYC8RwBZlX06uI+rn+coPZAcy4AYJYd5fwk3DkZtqZeuylgNKmMFfvZqD yMCA== X-Gm-Message-State: AJIora+p4hyHU/CTbGk/qFIVh/4R7qe40kftEo1XoqFovm1+lq/UKnwM Yv9JYLRHRb6LU+NqPLsyOln2s+upZSTwyjZDDvUTEK53YCY= X-Google-Smtp-Source: AGRyM1uhtAz31vRN2vTHNL4YCaPo/HzrRPqWvsF7BYkwB/9AbIB+WVtU7Zfj39rHx4IiBz8rcO0fuw5kZtT4pTTl5BA= X-Received: by 2002:ad4:5761:0:b0:473:7861:69d1 with SMTP id r1-20020ad45761000000b00473786169d1mr8093947qvx.73.1658688930682; Sun, 24 Jul 2022 11:55:30 -0700 (PDT) MIME-Version: 1.0 References: <20220724172442.87830-1-matti.lehtimaki@gmail.com> <20220724172442.87830-4-matti.lehtimaki@gmail.com> In-Reply-To: <20220724172442.87830-4-matti.lehtimaki@gmail.com> From: Dmitry Baryshkov Date: Sun, 24 Jul 2022 21:55:19 +0300 Message-ID: Subject: Re: [PATCH v3 3/3] ARM: dts: qcom: Add support for Samsung Galaxy Tab 4 10.1 (SM-T530) To: =?UTF-8?Q?Matti_Lehtim=C3=A4ki?= Cc: linux-arm-msm@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Arnd Bergmann , Olof Johansson , soc@kernel.org, Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sun, 24 Jul 2022 at 20:25, Matti Lehtim=C3=A4ki wrote: > > Add a device tree for the Samsung Galaxy Tab 4 10.1 (SM-T530) wifi tablet > based on the apq8026 platform. > > Currently supported are accelerometer sensor, hall sensor, > internal storage, physical buttons (power & volume), screen > (based on simple-framebuffer set up by the bootloader), sdcard, > touchscreen and USB. > > Signed-off-by: Matti Lehtim=C3=A4ki > --- > Changes in v3: > - Fix sdhc_2 bus width > - Reorder includes > > Changes in v2: > - Change codename to matisse-wifi > - Remove msm-id, not needed when lk2nd is used > - Remove unused labels from reserved memory regions > - Rename muic node > --- > arch/arm/boot/dts/Makefile | 1 + > .../dts/qcom-apq8026-samsung-matisse-wifi.dts | 469 ++++++++++++++++++ > 2 files changed, 470 insertions(+) > create mode 100644 arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.d= ts > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 5112f493f494..8bac4f4f8656 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -1010,6 +1010,7 @@ dtb-$(CONFIG_ARCH_QCOM) +=3D \ > qcom-apq8016-sbc.dtb \ > qcom-apq8026-asus-sparrow.dtb \ > qcom-apq8026-lg-lenok.dtb \ > + qcom-apq8026-samsung-matisse-wifi.dtb \ > qcom-apq8060-dragonboard.dtb \ > qcom-apq8064-cm-qs600.dtb \ > qcom-apq8064-ifc6410.dtb \ > diff --git a/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts b/ar= ch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts > new file mode 100644 > index 000000000000..78a119107069 > --- /dev/null > +++ b/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts > @@ -0,0 +1,469 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Copyright (c) 2022, Matti Lehtim=C3=A4ki > + */ > + > +/dts-v1/; > + > +#include > +#include "qcom-msm8226.dtsi" > +#include "qcom-pm8226.dtsi" > + > +/delete-node/ &smem_region; Please move this to the /reserved-memory node. having it there would help understanding that we are just changing the address. > + > +/ { > + model =3D "Samsung Galaxy Tab 4 10.1"; > + compatible =3D "samsung,matisse-wifi", "qcom,apq8026"; > + chassis-type =3D "tablet"; > + [skipped] > + i2c-muic { > + compatible =3D "i2c-gpio"; Is there any reason for using i2c-gpio rather than blsp_i2c4? According to the pinctrl-msm8226, gpio14/15 can be mapped to the blsp. > + sda-gpios =3D <&tlmm 14 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN= )>; > + scl-gpios =3D <&tlmm 15 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN= )>; > + > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&muic_i2c_default_state>; > + > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + > + muic: usb-switch@25 { > + compatible =3D "siliconmitus,sm5502-muic"; > + reg =3D <0x25>; > + > + interrupt-parent =3D <&tlmm>; > + interrupts =3D <67 IRQ_TYPE_EDGE_FALLING>; > + > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&muic_int_default_state>; > + }; > + }; [skipped] --=20 With best wishes Dmitry