From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F9C76AB4 for ; Tue, 3 Oct 2023 08:06:05 +0000 (UTC) Received: from mail-yw1-x1133.google.com (mail-yw1-x1133.google.com [IPv6:2607:f8b0:4864:20::1133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BAD85BB for ; Tue, 3 Oct 2023 01:06:03 -0700 (PDT) Received: by mail-yw1-x1133.google.com with SMTP id 00721157ae682-59f7cc71e2eso8057617b3.0 for ; Tue, 03 Oct 2023 01:06:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1696320363; x=1696925163; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=2+dCxHj9loHzO3/aljEjxLeeImmE0ebS+6n0wzTNDMU=; b=I/EdAr8xPZWXLEEj62X7a+wuYdYVmzHNiLeAyTv2FArjpMBUx0uGw2ianIOXSMc9Zi a4Ezx2ZvE7g6rnUWVVLXkFf0IYF9hlcP9jl4pPsQWAQ09vaqVeyxDiAxmzbCaxOorj7R z9PRrXzFe0z+pQK1sutAW2dJDrR14aMZp6SQsXEfoYeQbolzNCECf7fJjAxGN9IJ+3Ny gz3btNXbcowBBUAyCRBO1d8nz3+bqKJ2TXOsHzxd1giAkCS8cXv8yrUdxm09eFa2v8s4 s2BAT/yOcg82Nxb8DzxYU1XnHaBwrMRA7vAFiovpHvYbu1O+KW9xCrqEiU4p72k45TVR 6Vdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696320363; x=1696925163; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2+dCxHj9loHzO3/aljEjxLeeImmE0ebS+6n0wzTNDMU=; b=t9ec2l4clZtMd7BhtQ1Kf0sUzjQIrCLtHzxtJ3CMA14ZUBx9N6K4Gt4zVoJ3Ini0bC mvsBxAeW/A037HwHuqTWG+Yht3Qnq3b8EkHAxhMj7JTSaa5q+mVa5djz1HIIao9hLRsk Vq53w2vEzzV39cWJk/fCNcdBukwWqVdhr51SUkUHijN/eoYALGbtT5X/8IYRbZGC1HTl e6YOGUfKjOmhLZ/xRUaV+TX8knqswkMC3ysQDDWbC2zLlyYPpUQMKYIx/a2Sy2Sgnfsn yFZ149/gOYT2rAwtr4H4ZNcafGqZv6emMq3Z0rJcmbwnmL/IKChgZKEO8iweXVf/HUH2 VIVg== X-Gm-Message-State: AOJu0YxwnfOCtL4Mc8PAnyxo4X/MAtKxY/wH7Zsz34hgdZuECS7ZW2F0 Km+AQ40BF/nTKGKPvVU9rfcvlip2ugz9clg6cJLUhw== X-Google-Smtp-Source: AGHT+IEqOjI+FF8gpM0hRv7J/2E2f4vH+CKbR/ppRY5K+RPqgRFAcoDQY30fbiDlg5LJV3atYQuY9xVgWztpUkkKYdo= X-Received: by 2002:a0d:d54f:0:b0:59b:be67:84cb with SMTP id x76-20020a0dd54f000000b0059bbe6784cbmr13900277ywd.26.1696320362957; Tue, 03 Oct 2023 01:06:02 -0700 (PDT) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20231002-topic-sm8550-upstream-type-c-orientation-v2-0-125410d3ff95@linaro.org> <20231002-topic-sm8550-upstream-type-c-orientation-v2-2-125410d3ff95@linaro.org> In-Reply-To: From: Dmitry Baryshkov Date: Tue, 3 Oct 2023 11:05:51 +0300 Message-ID: Subject: Re: [PATCH v2 2/4] usb: ucsi: glink: use the connector orientation GPIO to provide switch events To: neil.armstrong@linaro.org Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heikki Krogerus , Greg Kroah-Hartman , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Tue, 3 Oct 2023 at 10:13, Neil Armstrong wrote: > > On 02/10/2023 19:26, Dmitry Baryshkov wrote: > > On Mon, 2 Oct 2023 at 13:21, Neil Armstrong wrote: > >> > >> On SM8550, the non-altmode orientation is not given anymore within > >> altmode events, even with USB SVIDs events. > >> > >> On the other side, the Type-C connector orientation is correctly > >> reported by a signal from the PMIC. > >> > >> Take this gpio signal when we detect some Type-C port activity > >> to notify any Type-C switches tied to the Type-C port connectors. > > > > Have you checked, which UCSI version is implemented on SM8550? > > Is there any chance of GET_CONNECTOR_STATUS / bit 86 actually > > reflecting the correct orientation? > > I checked, and no, the UCSI implementation is based on the UCSI 1.x spec, > and doesn't have the UCSI 2.x new bits. Ack, thanks for the confirmation. Reviewed-by: Dmitry Baryshkov > > Neil > > > > >> > >> Acked-by: Heikki Krogerus > >> Signed-off-by: Neil Armstrong > >> --- > > > > > -- With best wishes Dmitry